<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107510/">http://git.reviewboard.kde.org/r/107510/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 30th, 2012, 9:51 p.m., <b>Martin Engelmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I got the plugin working without any problems using the current master branch. Since the icons are not part of the diff I replaced them with symlinks to another icon before compiling.
I'm not a experienced developer, but here are my comments:
* Perhaps you could replace the QLabel to display the hint with a textbox. If the hints are quite long, then the dialog will grow instead of a line break.
* IIRC marking strings for translation is done by i18n(...) in KDE.
In another application I'm creating I had some trouble parsing the JSON reply of opencaching.com using QScriptEngine and QScriptValue. I used QJSON for that. However, I didn't notice any problems using your plugin.
Thank you for your work so far!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">About the hint: probably a good idea, although they tend to be relatively short, there is no known limit afaik.
Strings in marble use tr(), to facilitate the qt-only version, so afaik that is mandatory.
I had no trouble with the json parsing so far, and i scrolled quite a bit around the map. I was asked to not use qjson, to avoid the extra dependency I believe. :)
I will update the diffs later, I am implementing my "easy" improvements atm.</pre>
<br />
<p>- Anders</p>
<br />
<p>On November 29th, 2012, 8:51 a.m., Anders Lund wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Anders Lund.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2012, 8:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a render plugins showing geocaches from opencaching.com on the map.
Capabilities:
* shows geocaches on the map, using icons derived from opencaching.com graphics
* shows a tooltip with the most important data when icons are hovered
* provides a dialog with details, description, hint and recent logs for each geocache
* the dialog shows the distance to the cache if available, otherwise the distance to the users home location as known by marble (calculated at the time the dialog is shown)
Good translation support, ui and known translatable datas from the remote service are marked for translation.
The plugin is trying to use graphics and colors from the remote service in an unobtrusive way, so that the data is easily recognizable but does not interfer with the application or desktop style.
Possible future improvements:
* show geocache tags in graphical form (easy)
* show opencaching "verifyable" attributes for each cache (easy)
* allow registering/logging a visit to a cache (requires oauth based login)
* show users found caches by marking the icons with an emblem or special color (requires oauth based login)
* update distance data in dialog when it changes (easy)
* show a "go to" widget with live updated distance/bearing/course
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, compiles and functions</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/opencachingcom/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/CacheDetailsDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComPlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/multi-cache-m.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/multi-cache.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/opencachingcom.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/puzzle-m.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/puzzle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/traditional-m.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/traditional.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/unknown-m.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/unknown.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/virtual-m.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/virtual.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107510/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107510/s/858/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/29/marble-opencaching_400x100.png" style="border: 1px black solid;" alt="opencaching.com data and tooltip" /></a>
<a href="http://git.reviewboard.kde.org/r/107510/s/859/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/29/marble-opencaching-details_400x100.png" style="border: 1px black solid;" alt="Cache details dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>