[Marble-devel] Review Request: Build status summary in cmake runs

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107465/#review22720
-----------------------------------------------------------


This review has been submitted with commit b99121f6d1af1e291dd1bcf8f1654b2c8686556a by Dennis Nienhüser to branch kitchen.

- Commit Hook


On Nov. 25, 2012, 7 p.m., Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107465/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2012, 7 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> When running cmake, there should be a summary output that lists each possible dependency along with it's type, status and purpose.
> 
> The patch uses the FeatureSummary module of cmake and should be backwards-compatible to early 2.8.x versions (maybe also 2.6?) versions thanks to the marble_set_package_properties macro. Debian stable currently has cmake 2.8.2, so dropping support for cmake 2.6 would be ok in my opinion.
> 
> 
> This addresses bug 310378.
>     http://bugs.kde.org/show_bug.cgi?id=310378
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d9205a6 
>   MarbleMacros.cmake 5e1a1e5 
>   src/CMakeLists.txt b33ec4f 
>   src/plugins/positionprovider/CMakeLists.txt ba66150 
>   src/plugins/render/routing/CMakeLists.txt 5048da1 
>   src/plugins/runner/CMakeLists.txt cfc8a48 
> 
> Diff: http://git.reviewboard.kde.org/r/107465/diff/
> 
> 
> Testing
> -------
> 
> Output for the Qt version:
> 
> -- The following OPTIONAL packages have been found:
> 
>  * Phonon , cross-platform multimedia framework that enables the use of audio and video content , <http://qt.digia.com/>
>    Voice navigation (sound or human speakers)
>  * libshp , reading and writing of ESRI Shapefiles (.shp) , <http://shapelib.maptools.org/>
>    reading and displaying .shp files
>  * libgps , communicating with the GPS daemon , <http://catb.org/gpsd/>
>    position information via gpsd
>  * QtMobility , a collection of APIs and frameworks , <http://qt.digia.com/>
>    Required for QtLocation to work
>  * QtLocation , geographical support for position and map use , <http://qt.digia.com/>
>    position information via QtMobility QtLocation
>  * libwlocate , WLAN-based geolocation , <http://www.openwlanmap.org/>
>    Position information based on neighboring WLAN networks
> 
> -- The following REQUIRED packages have been found:
> 
>  * Qt4 , cross-platform application framework , <http://qt.digia.com/>
>    core framework
> 
> -- The following OPTIONAL packages have not been found:
> 
>  * liblocation , position information on Maemo 5 devices , <http://maemo.org/>
>    position information via GPS/WLAN for the Nokia N900 smartphone
> 
> -- Configuring done
> -- Generating done
> -- Build files have been written to: ...
> 
> 
> Output for the KDE version:
> 
> ...
> -- The following OPTIONAL packages have been found:
> 
>  * X11
>  * Threads
>  * Perl
>  * libshp , reading and writing of ESRI Shapefiles (.shp) , <http://shapelib.maptools.org/>
>    reading and displaying .shp files
>  * libgps , communicating with the GPS daemon , <http://catb.org/gpsd/>
>    position information via gpsd
>  * QtMobility , a collection of APIs and frameworks , <http://qt.digia.com/>
>    Required for QtLocation to work
>  * QtLocation , geographical support for position and map use , <http://qt.digia.com/>
>    position information via QtMobility QtLocation
>  * libwlocate , WLAN-based geolocation , <http://www.openwlanmap.org/>
>    Position information based on neighboring WLAN networks
> 
> -- The following REQUIRED packages have been found:
> 
>  * Qt4
>  * Automoc4
>  * KDE4 , technological foundation for KDE applications , <http://kde.org/>
>    KDE version of Marble
>  * Phonon , cross-platform multimedia framework that enables the use of audio and video content , <http://qt.digia.com/>
>    Voice navigation (sound or human speakers)
> 
> -- The following OPTIONAL packages have not been found:
> 
>  * liblocation , position information on Maemo 5 devices , <http://maemo.org/>
>    position information via GPS/WLAN for the Nokia N900 smartphone
> 
> -- The following REQUIRED packages have not been found:
> 
>  * KDE4Internal
> 
> -- Configuring done
> -- Generating done
> -- Build files have been written to: ...
> 
> 
> Thanks,
> 
> Dennis Nienhüser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121128/88b46838/attachment.html>