<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107465/">http://git.reviewboard.kde.org/r/107465/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b99121f6d1af1e291dd1bcf8f1654b2c8686556a by Dennis Nienhüser to branch kitchen.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 25th, 2012, 7 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2012, 7 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When running cmake, there should be a summary output that lists each possible dependency along with it's type, status and purpose.
The patch uses the FeatureSummary module of cmake and should be backwards-compatible to early 2.8.x versions (maybe also 2.6?) versions thanks to the marble_set_package_properties macro. Debian stable currently has cmake 2.8.2, so dropping support for cmake 2.6 would be ok in my opinion.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Output for the Qt version:
-- The following OPTIONAL packages have been found:
* Phonon , cross-platform multimedia framework that enables the use of audio and video content , <http://qt.digia.com/>
Voice navigation (sound or human speakers)
* libshp , reading and writing of ESRI Shapefiles (.shp) , <http://shapelib.maptools.org/>
reading and displaying .shp files
* libgps , communicating with the GPS daemon , <http://catb.org/gpsd/>
position information via gpsd
* QtMobility , a collection of APIs and frameworks , <http://qt.digia.com/>
Required for QtLocation to work
* QtLocation , geographical support for position and map use , <http://qt.digia.com/>
position information via QtMobility QtLocation
* libwlocate , WLAN-based geolocation , <http://www.openwlanmap.org/>
Position information based on neighboring WLAN networks
-- The following REQUIRED packages have been found:
* Qt4 , cross-platform application framework , <http://qt.digia.com/>
core framework
-- The following OPTIONAL packages have not been found:
* liblocation , position information on Maemo 5 devices , <http://maemo.org/>
position information via GPS/WLAN for the Nokia N900 smartphone
-- Configuring done
-- Generating done
-- Build files have been written to: ...
Output for the KDE version:
...
-- The following OPTIONAL packages have been found:
* X11
* Threads
* Perl
* libshp , reading and writing of ESRI Shapefiles (.shp) , <http://shapelib.maptools.org/>
reading and displaying .shp files
* libgps , communicating with the GPS daemon , <http://catb.org/gpsd/>
position information via gpsd
* QtMobility , a collection of APIs and frameworks , <http://qt.digia.com/>
Required for QtLocation to work
* QtLocation , geographical support for position and map use , <http://qt.digia.com/>
position information via QtMobility QtLocation
* libwlocate , WLAN-based geolocation , <http://www.openwlanmap.org/>
Position information based on neighboring WLAN networks
-- The following REQUIRED packages have been found:
* Qt4
* Automoc4
* KDE4 , technological foundation for KDE applications , <http://kde.org/>
KDE version of Marble
* Phonon , cross-platform multimedia framework that enables the use of audio and video content , <http://qt.digia.com/>
Voice navigation (sound or human speakers)
-- The following OPTIONAL packages have not been found:
* liblocation , position information on Maemo 5 devices , <http://maemo.org/>
position information via GPS/WLAN for the Nokia N900 smartphone
-- The following REQUIRED packages have not been found:
* KDE4Internal
-- Configuring done
-- Generating done
-- Build files have been written to: ...</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=310378">310378</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d9205a6)</span></li>
<li>MarbleMacros.cmake <span style="color: grey">(5e1a1e5)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b33ec4f)</span></li>
<li>src/plugins/positionprovider/CMakeLists.txt <span style="color: grey">(ba66150)</span></li>
<li>src/plugins/render/routing/CMakeLists.txt <span style="color: grey">(5048da1)</span></li>
<li>src/plugins/runner/CMakeLists.txt <span style="color: grey">(cfc8a48)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107465/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>