[Marble-devel] Review Request: UI enhancement for global/area search toggle

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107195/#review21642
-----------------------------------------------------------


This review has been submitted with commit 339f9da4cf9fec4a3f9b428f1760131adca225ae by Dennis Nienhüser to branch master.

- Commit Hook


On Nov. 4, 2012, 5:06 p.m., Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107195/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2012, 5:06 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Currently there's a checkbox in the Navigation tab with the text "Around" which, when enabled, switches from global search to bounded (search visible map region only) mode. I'd like to make that mode switch more intuitive to users by doing two changes:
> - Move the checkbox to the search input field such that it becomes part of the search widget
> - Use a radio button like approach instead of a checkbox
> 
> The patch implements that using a drop down menu on the search decorator of the search line edit (see screenshots).
> 
> 
> Diffs
> -----
> 
>   src/ControlView.h 4eb0633 
>   src/ControlView.cpp fc099ef 
>   src/QtMainWindow.cpp 1711900 
>   src/icons/16x16/edit-find.png d9d1c7c 
>   src/lib/MarbleControlBox.h c0123e7 
>   src/lib/MarbleControlBox.cpp 66bbbde 
>   src/lib/MarbleGlobal.h 79485fc 
>   src/lib/MarbleLineEdit.cpp 0ceb42c 
>   src/lib/NavigationWidget.h f28e892 
>   src/lib/NavigationWidget.cpp 1dac315 
>   src/lib/NavigationWidget.ui 859682d 
>   src/lib/SearchInputWidget.h 1d7c8fe 
>   src/lib/SearchInputWidget.cpp 72607b3 
> 
> Diff: http://git.reviewboard.kde.org/r/107195/diff/
> 
> 
> Testing
> -------
> 
> Toggle between modes, make sure that a) placeholder text indicates "Global Search" or "Area Search", respectively, and search results are appropriate for the mode in question
> 
> 
> Screenshots
> -----------
> 
> Extended search widget. Checkbox in Navigation tab removed, search decorator button drop down indicator added, placeholder text indicates mode
>   http://git.reviewboard.kde.org/r/107195/s/811/
> Mode toggle. Actions implement a radio button behavior two make the two modes explicit
>   http://git.reviewboard.kde.org/r/107195/s/812/
> 
> 
> Thanks,
> 
> Dennis Nienhüser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121108/595dfd90/attachment.html>