<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107195/">http://git.reviewboard.kde.org/r/107195/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 339f9da4cf9fec4a3f9b428f1760131adca225ae by Dennis Nienhüser to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 4th, 2012, 5:06 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2012, 5:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently there's a checkbox in the Navigation tab with the text "Around" which, when enabled, switches from global search to bounded (search visible map region only) mode. I'd like to make that mode switch more intuitive to users by doing two changes:
- Move the checkbox to the search input field such that it becomes part of the search widget
- Use a radio button like approach instead of a checkbox
The patch implements that using a drop down menu on the search decorator of the search line edit (see screenshots).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Toggle between modes, make sure that a) placeholder text indicates "Global Search" or "Area Search", respectively, and search results are appropriate for the mode in question
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ControlView.h <span style="color: grey">(4eb0633)</span></li>
<li>src/ControlView.cpp <span style="color: grey">(fc099ef)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(1711900)</span></li>
<li>src/icons/16x16/edit-find.png <span style="color: grey">(d9d1c7c)</span></li>
<li>src/lib/MarbleControlBox.h <span style="color: grey">(c0123e7)</span></li>
<li>src/lib/MarbleControlBox.cpp <span style="color: grey">(66bbbde)</span></li>
<li>src/lib/MarbleGlobal.h <span style="color: grey">(79485fc)</span></li>
<li>src/lib/MarbleLineEdit.cpp <span style="color: grey">(0ceb42c)</span></li>
<li>src/lib/NavigationWidget.h <span style="color: grey">(f28e892)</span></li>
<li>src/lib/NavigationWidget.cpp <span style="color: grey">(1dac315)</span></li>
<li>src/lib/NavigationWidget.ui <span style="color: grey">(859682d)</span></li>
<li>src/lib/SearchInputWidget.h <span style="color: grey">(1d7c8fe)</span></li>
<li>src/lib/SearchInputWidget.cpp <span style="color: grey">(72607b3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107195/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107195/s/811/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/04/marble-ui-area-search-1_400x100.png" style="border: 1px black solid;" alt="Extended search widget. Checkbox in Navigation tab removed, search decorator button drop down indicator added, placeholder text indicates mode" /></a>
<a href="http://git.reviewboard.kde.org/r/107195/s/812/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/04/marble-ui-area-search-2_400x100.png" style="border: 1px black solid;" alt="Mode toggle. Actions implement a radio button behavior two make the two modes explicit" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>