[Marble-devel] Review Request: Install separate desktop files for all mimetypes supported by Marble

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107015/#review21403
-----------------------------------------------------------

Ship it!


Looks good :)


src/plugins/runner/osm/marble_part_osm.desktop
<http://git.reviewboard.kde.org/r/107015/#comment16633>

    Isn't that a user visible, translated string? Then I'd strip off 'Part' as it is too technical


- Dennis Nienhüser


On Oct. 23, 2012, 9:15 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107015/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 9:15 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Do like Okular does, separate desktop files per all installed plugins. So with distris which package each plugin in a separate package Marble will never claim to support a file type until it really does.
> 
> See also http://lists.kde.org/?l=kde-devel&m=135083816331959&w=2 and comment from Thibaut on http://git.reviewboard.kde.org/r/106977/
> 
> 
> Diffs
> -----
> 
>   src/marble.desktop 0808f93 
>   src/marble_part.desktop e6146d4 
>   src/plugins/runner/gpx/CMakeLists.txt bee89ac 
>   src/plugins/runner/gpx/marble_gpx.desktop PRE-CREATION 
>   src/plugins/runner/gpx/marble_part_gpx.desktop PRE-CREATION 
>   src/plugins/runner/kml/CMakeLists.txt f92b313 
>   src/plugins/runner/kml/marble_kml.desktop PRE-CREATION 
>   src/plugins/runner/kml/marble_part_kml.desktop PRE-CREATION 
>   src/plugins/runner/osm/CMakeLists.txt 3ee2475 
>   src/plugins/runner/osm/marble_osm.desktop PRE-CREATION 
>   src/plugins/runner/osm/marble_part_osm.desktop PRE-CREATION 
>   src/plugins/runner/shp/CMakeLists.txt d3d9ccd 
> 
> Diff: http://git.reviewboard.kde.org/r/107015/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121104/be1eaa08/attachment.html>