<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107015/">http://git.reviewboard.kde.org/r/107015/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good :)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107015/diff/1/?file=92138#file92138line3" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/osm/marble_part_osm.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Name=Marble Part</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't that a user visible, translated string? Then I'd strip off 'Part' as it is too technical</pre>
</div>
<br />
<p>- Dennis</p>
<br />
<p>On October 23rd, 2012, 9:15 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2012, 9:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do like Okular does, separate desktop files per all installed plugins. So with distris which package each plugin in a separate package Marble will never claim to support a file type until it really does.
See also http://lists.kde.org/?l=kde-devel&m=135083816331959&w=2 and comment from Thibaut on http://git.reviewboard.kde.org/r/106977/
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/marble.desktop <span style="color: grey">(0808f93)</span></li>
<li>src/marble_part.desktop <span style="color: grey">(e6146d4)</span></li>
<li>src/plugins/runner/gpx/CMakeLists.txt <span style="color: grey">(bee89ac)</span></li>
<li>src/plugins/runner/gpx/marble_gpx.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/marble_part_gpx.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/kml/CMakeLists.txt <span style="color: grey">(f92b313)</span></li>
<li>src/plugins/runner/kml/marble_kml.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/kml/marble_part_kml.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/CMakeLists.txt <span style="color: grey">(3ee2475)</span></li>
<li>src/plugins/runner/osm/marble_osm.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/marble_part_osm.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/shp/CMakeLists.txt <span style="color: grey">(d3d9ccd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107015/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>