[Marble-devel] Review Request: Fix painting of polygons with holes

Dennis Nienhüser earthwings at gentoo.org
Wed May 23 07:54:35 UTC 2012

This is an automatically generated e-mail. To reply, visit:

Review request for Marble.


Currently GeoPainter renders Polygons wrong if they have an outline pen and are filled (think of buildings): A QPolygonF is created from the outer boundary and the inner rings are subtracted. Now QPainter paints the stroke of such Polygons by connecting each point, leading to unwanted connections between the outer boundary and the inner holes. See http://i.imgur.com/25rjs.png (from Ander).

The patch changes this to paint the background (brush) as previous, but paints the outer and inner rings' outlines individually. Please review with performance in mind. Any ideas how to paint everything in one go (should be faster)?


  src/lib/GeoPainter.cpp aa18e47 

Diff: http://git.reviewboard.kde.org/r/105019/diff/



Dennis Nienhüser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120523/f5d7575f/attachment.html>

More information about the Marble-devel mailing list