[Marble-devel] Review Request: Generic About Dialog

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104352/#review11743
-----------------------------------------------------------


This review has been submitted with commit 26cc47cb42a109ae33f7b9527a13f9da50bb4a6d by Bernhard Beschow to branch master.

- Commit Hook


On March 21, 2012, 11:02 a.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104352/
> -----------------------------------------------------------
> 
> (Updated March 21, 2012, 11:02 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Fill our existing about dialog with metadata from the PluginInterface. The two objectives of the patch are to make our plugins more independent from QWidget, and to present about data in a uniform fashion.
> 
> The PluginInterface has gained a new virtual method, aboutDataText(), which shall return license information for the data used in the implementing plugin. For the case where a plugin doesn't use external data (such as our file plugins), a default implementation is provided for convenience, which returns the empty QString (no license involved).
> 
> Questions:
> * Is the metadata sufficient to cover metadata for all possible plugin types?
> * Do we still need a way to create specialized about dialogs, depending on the plugin?
> 
> 
> Diffs
> -----
> 
>   src/lib/PluginInterface.h d098453c37db861b3e584f181645f4749bd456e9 
>   src/lib/PluginInterface.cpp 4932c5aff4bbf912f9e4fd5935e7f10c944c6c03 
>   src/lib/QtMarbleConfigDialog.cpp bd7d9043df18dc7cf734675363b75c615acaf176 
>   src/lib/RenderPlugin.h 3fd92497d8b8977b866f3d7844ab1ccf1ae0d26e 
>   src/lib/RenderPlugin.cpp 8e78237af3806532e0c69c4c6546bb3442c109bc 
>   src/marble_part.cpp 418f87769daa179d23a67621bbcf16f4c57fed2f 
>   src/plugins/render/satellites/SatellitesPlugin.h 4702b6d29ad901073b60eedc4bee21022689cc63 
>   src/plugins/render/satellites/SatellitesPlugin.cpp 65ead37cfe99db873a121d92a3a581f92d84c06b 
>   src/plugins/render/weather/WeatherPlugin.h 6f41135cd0722befe3e8905781b9ef5f61b557e8 
>   src/plugins/render/weather/WeatherPlugin.cpp d6038af00b9a157185387ffaa5650e227d9cbce5 
>   src/plugins/render/wikipedia/WikipediaPlugin.h b1f187bdda41fe17b811398de225b6169e180a63 
>   src/plugins/render/wikipedia/WikipediaPlugin.cpp 1f4c954261cbaf4e1b7b557885864a8fd013010d 
> 
> Diff: http://git.reviewboard.kde.org/r/104352/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120322/ff4753e6/attachment.html>