<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104352/">http://git.reviewboard.kde.org/r/104352/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 26cc47cb42a109ae33f7b9527a13f9da50bb4a6d by Bernhard Beschow to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 21st, 2012, 11:02 a.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated March 21, 2012, 11:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fill our existing about dialog with metadata from the PluginInterface. The two objectives of the patch are to make our plugins more independent from QWidget, and to present about data in a uniform fashion.
The PluginInterface has gained a new virtual method, aboutDataText(), which shall return license information for the data used in the implementing plugin. For the case where a plugin doesn't use external data (such as our file plugins), a default implementation is provided for convenience, which returns the empty QString (no license involved).
Questions:
* Is the metadata sufficient to cover metadata for all possible plugin types?
* Do we still need a way to create specialized about dialogs, depending on the plugin?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/PluginInterface.h <span style="color: grey">(d098453c37db861b3e584f181645f4749bd456e9)</span></li>
<li>src/lib/PluginInterface.cpp <span style="color: grey">(4932c5aff4bbf912f9e4fd5935e7f10c944c6c03)</span></li>
<li>src/lib/QtMarbleConfigDialog.cpp <span style="color: grey">(bd7d9043df18dc7cf734675363b75c615acaf176)</span></li>
<li>src/lib/RenderPlugin.h <span style="color: grey">(3fd92497d8b8977b866f3d7844ab1ccf1ae0d26e)</span></li>
<li>src/lib/RenderPlugin.cpp <span style="color: grey">(8e78237af3806532e0c69c4c6546bb3442c109bc)</span></li>
<li>src/marble_part.cpp <span style="color: grey">(418f87769daa179d23a67621bbcf16f4c57fed2f)</span></li>
<li>src/plugins/render/satellites/SatellitesPlugin.h <span style="color: grey">(4702b6d29ad901073b60eedc4bee21022689cc63)</span></li>
<li>src/plugins/render/satellites/SatellitesPlugin.cpp <span style="color: grey">(65ead37cfe99db873a121d92a3a581f92d84c06b)</span></li>
<li>src/plugins/render/weather/WeatherPlugin.h <span style="color: grey">(6f41135cd0722befe3e8905781b9ef5f61b557e8)</span></li>
<li>src/plugins/render/weather/WeatherPlugin.cpp <span style="color: grey">(d6038af00b9a157185387ffaa5650e227d9cbce5)</span></li>
<li>src/plugins/render/wikipedia/WikipediaPlugin.h <span style="color: grey">(b1f187bdda41fe17b811398de225b6169e180a63)</span></li>
<li>src/plugins/render/wikipedia/WikipediaPlugin.cpp <span style="color: grey">(1f4c954261cbaf4e1b7b557885864a8fd013010d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104352/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>