[Marble-devel] Review Request: don't paint default background for OSM vector data

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105253/#review16323
-----------------------------------------------------------


This review has been submitted with commit 94a25c6531566e0d1c85dbe997d6709955d480a7 by Bernhard Beschow to branch sok-2012-plasma-active.

- Commit Hook


On June 14, 2012, 7:17 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105253/
> -----------------------------------------------------------
> 
> (Updated June 14, 2012, 7:17 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> == Motivation ==
> The default background has always the same color, regardless of wheter it covers sea or land mass. As a result, information from the underlying (base) layer gets hidden, e.g. satellite imagery. By not painting a default background, information is preserved for areas where no OSM data is available, while allowing any map theme to be enriched by OSM vector data.
> 
> In addition, this patch assigns a bbox to the GeoDataDocument. Please check whether this is done correctly.
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/osm/handlers/OsmBoundsTagHandler.cpp fc828e0da13dcb592ddbc17451efede56a9181e2 
> 
> Diff: http://git.reviewboard.kde.org/r/105253/diff/
> 
> 
> Testing
> -------
> 
> No background is painted, as intended. However, the area is still zoomed out too far when the .osm file has finished loading.
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120724/47f61d35/attachment-0001.html>