[Marble-devel] Review Request: Fix automagic dependencies in Marble

Commit Hook null at kde.org
Tue Jul 24 20:48:48 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105598/#review16324
-----------------------------------------------------------


This review has been submitted with commit 284c2c836fd599bcfb1da4763e0bafb26254f088 by Michael Palimaka to branch sok-2012-plasma-active.

- Commit Hook


On July 17, 2012, 1:17 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105598/
> -----------------------------------------------------------
> 
> (Updated July 17, 2012, 1:17 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> The dependencies required to build Marble plugins are currently automagic - there is no way for the end user to disable them if the dependency is present.
> 
> This patch simply fixes that, adding new configure options -DWITH_{libgps,liblocation,QtLocation}.
> 
> 
> Diffs
> -----
> 
>   MarbleMacros.cmake 9e382614819f2bc55e61ca82e15614139bc5ff1b 
>   src/plugins/positionprovider/CMakeLists.txt 43e3b1373728553b634cf1c0ce7c078adcb8aad0 
> 
> Diff: http://git.reviewboard.kde.org/r/105598/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120724/10abf1f6/attachment.html>


More information about the Marble-devel mailing list