[Marble-devel] Review Request: ElevationProfile: Refactoring

Florian Eßer f.esser at rwth-aachen.de
Wed Jan 25 18:07:22 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103793/
-----------------------------------------------------------

Review request for Marble.


Description
-------

Refactoring of the ElevationProfile plugin code.
* axis handling moved to a dedicated class, no more double-code for X and Y scale calculation
* try to generate 'nicer' interval ticks, e.g. 42.5 instead of 42.444
* "double click -> jump to location" now works in zoom mode, too
* minor optical changes
* shortened the "Elevation difference" text to not get cropped in Marble Touch


Diffs
-----

  src/plugins/render/elevationprofile/CMakeLists.txt f6fb1f3 
  src/plugins/render/elevationprofile/ElevationProfileFloatItem.h 16e5ea3 
  src/plugins/render/elevationprofile/ElevationProfileFloatItem.cpp 15b8084 
  src/plugins/render/elevationprofile/ElevationProfilePlotAxis.h PRE-CREATION 
  src/plugins/render/elevationprofile/ElevationProfilePlotAxis.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103793/diff/diff


Testing
-------

not yet tested for imperial units


Thanks,

Florian Eßer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120125/8249c4df/attachment.html>


More information about the Marble-devel mailing list