[Marble-devel] Review Request: Endorse marble/class.h #includes to libraries (instead of simple class.h)

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103656/
-----------------------------------------------------------

Review request for Marble.


Description
-------

Our current FindMarble.cmake script installed to the cmake module path puts the marble suffix into the include search path. This means that an
#include <marble/MarbleWidget.h>
does not work in general (only if the path below happens to be in the search path by some other reasons, e.g. because it is the standard path /usr/include). This is quite bad as something like #include <global.h> is likely to clash with other libraries' includes.


This addresses bug 282865.
    http://bugs.kde.org/show_bug.cgi?id=282865


Diffs
-----

  FindMarble.cmake 7f81911 

Diff: http://git.reviewboard.kde.org/r/103656/diff/diff


Testing
-------

The examples in examples/cpp (which have <marble/class.h> includes) now work for local installations when configuring cmake with

cmake -DCMAKE_MODULE_PATH=~/marble/export/share/marble/cmake \
      -DCMAKE_INCLUDE_PATH=~/marble/export/include \
      -DCMAKE_LIBRARY_PATH=~/marble/export/lib \
      .

Previously MARBLE_INCLUDE_DIR hat to be adjusted manually.


Thanks,

Dennis Nienhüser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120108/cd020729/attachment.html>