[Marble-devel] Review Request: Fix for compiler warnings

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103640/#review9642
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On Jan. 6, 2012, 6:45 p.m., Siddharth Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103640/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2012, 6:45 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> - added Q_UNUSED for unused variables.
> - corrected the indentation in sgp4unit.cpp to avoid ambiguous 'else'
> - fixed uninitialized variables
> 
> (thought its the best place to start again :) )
> 
> 
> Diffs
> -----
> 
>   src/lib/VectorMap.cpp 1430912 
>   src/plugins/render/satellites/SatellitesConfigAbstractItem.cpp 53042ea 
>   src/plugins/render/satellites/sgp4/sgp4io.cpp 6f1419a 
>   src/plugins/render/satellites/sgp4/sgp4unit.cpp a8b6f62 
> 
> Diff: http://git.reviewboard.kde.org/r/103640/diff/diff
> 
> 
> Testing
> -------
> 
> Works fine on my side.
> 
> 
> Thanks,
> 
> Siddharth Srivastava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120107/d955ce54/attachment.html>