[Marble-devel] Review Request: Fix for compiler warnings

Siddharth Srivastava akssps011 at gmail.com
Fri Jan 6 18:45:07 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103640/
-----------------------------------------------------------

Review request for Marble.


Description
-------

- added Q_UNUSED for unused variables.
- corrected the indentation in sgp4unit.cpp to avoid ambiguous 'else'
- fixed uninitialized variables

(thought its the best place to start again :) )


Diffs
-----

  src/lib/VectorMap.cpp 1430912 
  src/plugins/render/satellites/SatellitesConfigAbstractItem.cpp 53042ea 
  src/plugins/render/satellites/sgp4/sgp4io.cpp 6f1419a 
  src/plugins/render/satellites/sgp4/sgp4unit.cpp a8b6f62 

Diff: http://git.reviewboard.kde.org/r/103640/diff/diff


Testing
-------

Works fine on my side.


Thanks,

Siddharth Srivastava

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120106/841468a1/attachment.html>


More information about the Marble-devel mailing list