[Marble-devel] Review Request: Initial support for ESRI shapefiles

Commit Hook null at kde.org
Thu Feb 16 21:10:15 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102867/#review10689
-----------------------------------------------------------


This review has been submitted with commit b20410b68d74fa760e17ee5567971fe34c3c3b56 by Thibaut Gridel to branch master.

- Commit Hook


On Oct. 14, 2011, 9:47 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102867/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2011, 9:47 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This file parser plugin creates a geodatadocument with the most basic shapes from shp spec.
> It also tries to find Name and Note data from the dbf file and maps it to placemark name and description.
> 
> The plugin links against libshp (http://shapelib.maptools.org).
> Absolutely no styling done, because the file spec is really too generic and data means anything.
> 
> 
> This addresses bug 166166.
>     http://bugs.kde.org/show_bug.cgi?id=166166
> 
> 
> Diffs
> -----
> 
>   Findlibshp.cmake PRE-CREATION 
>   src/QtMainWindow.cpp e57feca 
>   src/plugins/runner/CMakeLists.txt fd644a6 
>   src/plugins/runner/shp/CMakeLists.txt PRE-CREATION 
>   src/plugins/runner/shp/ShpPlugin.h PRE-CREATION 
>   src/plugins/runner/shp/ShpPlugin.cpp PRE-CREATION 
>   src/plugins/runner/shp/ShpRunner.h PRE-CREATION 
>   src/plugins/runner/shp/ShpRunner.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102867/diff/
> 
> 
> Testing
> -------
> 
> Loading 10m data from naturalEarth.
> See attached screenshots.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102867/s/304/
> 
>   http://git.reviewboard.kde.org/r/102867/s/305/
> 
> 
> Thanks,
> 
> Thibaut Gridel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120216/7b5c064f/attachment.html>


More information about the Marble-devel mailing list