<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102867/">http://git.reviewboard.kde.org/r/102867/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b20410b68d74fa760e17ee5567971fe34c3c3b56 by Thibaut Gridel to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 14th, 2011, 9:47 p.m., Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2011, 9:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This file parser plugin creates a geodatadocument with the most basic shapes from shp spec.
It also tries to find Name and Note data from the dbf file and maps it to placemark name and description.
The plugin links against libshp (http://shapelib.maptools.org).
Absolutely no styling done, because the file spec is really too generic and data means anything.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Loading 10m data from naturalEarth.
See attached screenshots.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=166166">166166</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>Findlibshp.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(e57feca)</span></li>
<li>src/plugins/runner/CMakeLists.txt <span style="color: grey">(fd644a6)</span></li>
<li>src/plugins/runner/shp/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/shp/ShpPlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/shp/ShpPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/shp/ShpRunner.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/shp/ShpRunner.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102867/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102867/s/304/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/10/14/shp_10m_coast_kiel_400x100.jpeg" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/102867/s/305/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/10/14/shp_11m_coast_kiel_osm_400x100.jpeg" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>