[Marble-devel] Review Request: No unnecessary tile redownloads when downloading a region/route

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103864/#review10349
-----------------------------------------------------------

Ship it!


Looks good, refactors state of a given tile in one place for reuse in many :)

- Thibaut Gridel


On Feb. 4, 2012, 10:59 a.m., Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103864/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2012, 10:59 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> When requesting to download a region/route, currently all affected tiles are downloaded, regardless whether they already exist on disk. A duplication check is done for files in the download queue, but additionally it should be checked whether a file already exists and is not expired.
> 
> Not downloading these tiles again makes downloading regions much faster and removes some burden from the servers downloaded from.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMap.cpp 90238da 
>   src/lib/StackedTileLoader.h df7c31e 
>   src/lib/StackedTileLoader.cpp 96c737a 
>   src/lib/TileLoader.h 0c088a7 
>   src/lib/TileLoader.cpp c6e79e3 
>   src/lib/layers/TextureLayer.h efc9ef2 
>   src/lib/layers/TextureLayer.cpp a7943bf 
> 
> Diff: http://git.reviewboard.kde.org/r/103864/diff/diff
> 
> 
> Testing
> -------
> 
> Downloading regions and checking that
> - not yet existing tiles are downloaded
> - expired tiles are downloaded (touch -d 'last month' path/to/tile is your friend)
> - already available tiles are not queued for download
> 
> 
> Thanks,
> 
> Dennis Nienhüser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120205/9603ebf4/attachment.html>