<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103864/">http://git.reviewboard.kde.org/r/103864/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, refactors state of a given tile in one place for reuse in many :)</pre>
<br />
<p>- Thibaut</p>
<br />
<p>On February 4th, 2012, 10:59 a.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2012, 10:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When requesting to download a region/route, currently all affected tiles are downloaded, regardless whether they already exist on disk. A duplication check is done for files in the download queue, but additionally it should be checked whether a file already exists and is not expired.
Not downloading these tiles again makes downloading regions much faster and removes some burden from the servers downloaded from.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Downloading regions and checking that
- not yet existing tiles are downloaded
- expired tiles are downloaded (touch -d 'last month' path/to/tile is your friend)
- already available tiles are not queued for download
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleMap.cpp <span style="color: grey">(90238da)</span></li>
<li>src/lib/StackedTileLoader.h <span style="color: grey">(df7c31e)</span></li>
<li>src/lib/StackedTileLoader.cpp <span style="color: grey">(96c737a)</span></li>
<li>src/lib/TileLoader.h <span style="color: grey">(0c088a7)</span></li>
<li>src/lib/TileLoader.cpp <span style="color: grey">(c6e79e3)</span></li>
<li>src/lib/layers/TextureLayer.h <span style="color: grey">(efc9ef2)</span></li>
<li>src/lib/layers/TextureLayer.cpp <span style="color: grey">(a7943bf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103864/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>