[Marble-devel] Review Request: [GCI] KML tag writers

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107972/#review24143
-----------------------------------------------------------


Great work, thanks. The Polygon and TimeSpan writer work as expected. The two overlay writers miss some information. Could you create a base class KmlOverlayWriter that helps to write the missing <Icon><href>...</href></Icon> information? See KmlIconStyleTagWriter and KmlColorStyleTagWriter as an example.



src/lib/geodata/writers/kml/KmlGroundOverlayWriter.cpp
<http://git.reviewboard.kde.org/r/107972/#comment18471>

    Unfortunately the KmlLatLonBoxWriter hasn't been written yet. Do you feel like doing that as well? :-)
    



src/lib/geodata/writers/kml/KmlPhotoOverlayWriter.cpp
<http://git.reviewboard.kde.org/r/107972/#comment18472>

    Shouldn't be needed - indeed a nested <Point><Point> ... </Point></Point> ends up in the .kml.


- Dennis Nienhüser


On Dec. 28, 2012, 10:51 a.m., Shou Ya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107972/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2012, 10:51 a.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Description
> -------
> 
> Create kml tag writers for Polygon, PhotoOverlay, GroundOverlay and TimeSpan.
> 
> 
> This is a GCI task on https://www.google-melange.com/gci/task/view/google/gci2012/8020204 .
> 
> 
> This addresses bug 310576.
>     http://bugs.kde.org/show_bug.cgi?id=310576
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/writers/kml/KmlGroundOverlayWriter.h PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlGroundOverlayWriter.cpp PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlPhotoOverlayWriter.h PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlPhotoOverlayWriter.cpp PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlPolygonTagWriter.h PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlPolygonTagWriter.cpp PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlTimeSpanWriter.h PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlTimeSpanWriter.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107972/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shou Ya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121228/c45061ef/attachment.html>