<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107972/">http://git.reviewboard.kde.org/r/107972/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great work, thanks. The Polygon and TimeSpan writer work as expected. The two overlay writers miss some information. Could you create a base class KmlOverlayWriter that helps to write the missing <Icon><href>...</href></Icon> information? See KmlIconStyleTagWriter and KmlColorStyleTagWriter as an example.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107972/diff/1/?file=102085#file102085line53" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/geodata/writers/kml/KmlGroundOverlayWriter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KmlGroundOverlayWriter::write( const GeoNode *node,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">writeElement</span><span class="p">(</span> <span class="o">&</span><span class="n">ground_overlay</span><span class="o">-></span><span class="n">latLonBox</span><span class="p">(),</span> <span class="n">writer</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unfortunately the KmlLatLonBoxWriter hasn't been written yet. Do you feel like doing that as well? :-)
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107972/diff/1/?file=102087#file102087line33" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/geodata/writers/kml/KmlPhotoOverlayWriter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KmlPhotoOverlayWriter::write( const GeoNode *node, GeoWriter& writer ) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">writer</span><span class="p">.</span><span class="n">writeStartElement</span><span class="p">(</span> <span class="s">"Point"</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't be needed - indeed a nested <Point><Point> ... </Point></Point> ends up in the .kml.</pre>
</div>
<br />
<p>- Dennis</p>
<br />
<p>On December 28th, 2012, 10:51 a.m., Shou Ya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Dennis Nienhüser.</div>
<div>By Shou Ya.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2012, 10:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create kml tag writers for Polygon, PhotoOverlay, GroundOverlay and TimeSpan.
This is a GCI task on https://www.google-melange.com/gci/task/view/google/gci2012/8020204 .</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=310576">310576</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/geodata/writers/kml/KmlGroundOverlayWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/writers/kml/KmlGroundOverlayWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/writers/kml/KmlPhotoOverlayWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/writers/kml/KmlPhotoOverlayWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/writers/kml/KmlPolygonTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/writers/kml/KmlPolygonTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/writers/kml/KmlTimeSpanWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/writers/kml/KmlTimeSpanWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107972/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>