[Marble-devel] Review Request: Render Copyright/License on the Map

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107620/#review23324
-----------------------------------------------------------



src/plugins/render/license/LicenseLabel.h
<http://git.reviewboard.kde.org/r/107620/#comment17938>

    If we would use this then why would you want to introduce a "usedFont()" method? There is setFont() and font() already there which you can use.



src/plugins/render/license/LicenseLabel.h
<http://git.reviewboard.kde.org/r/107620/#comment17939>

    pText? :) what is the "p" for?



src/plugins/render/license/LicenseLabel.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17940>

    Usually we don't abbreviate variable names.
    Especially not when there is a possible meaning ambivalence  GEOgraphy vs. GEOmetry


- Torsten Rahn


On Dec. 11, 2012, 7:27 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107620/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2012, 7:27 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Description
> -------
> 
> Task was solved according to the statements:
>  1. https://google-melange.appspot.com/gci/task/view/google/gci2012/8015212
>  2. http://www.google-melange.com/gci/task/view/google/gci2012/8006226
>  3. http://www.google-melange.com/gci/task/view/google/gci2012/8018213
>  4. http://www.google-melange.com/gci/task/view/google/gci2012/7959252
> 
> 
> Diffs
> -----
> 
>   data/maps/earth/bluemarble/bluemarble.dgml 5eb6e2b 
>   data/maps/earth/citylights/citylights.dgml 8db9b13 
>   data/maps/earth/openstreetmap/openstreetmap.dgml b26e5e1 
>   data/maps/earth/plain/plain.dgml e27eda2 
>   data/maps/earth/temp-july/temp-july.dgml e8372df 
>   src/ControlView.h 756ecb7 
>   src/ControlView.cpp 55d56f5 
>   src/QtMainWindow.cpp ae34e7c 
>   src/lib/AbstractFloatItem.cpp 15ceebb 
>   src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.h 8a590e8 
>   src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.cpp c8b6f99 
>   src/lib/geodata/handlers/dgml/DgmlLicenseTagHandler.cpp 9b8a7bc 
>   src/lib/geodata/scene/GeoSceneLicense.h 7176c12 
>   src/lib/geodata/scene/GeoSceneLicense.cpp c5a5e6d 
>   src/lib/graphicsview/ScreenGraphicsItem.h ef19746 
>   src/plugins/render/CMakeLists.txt 4e550c0 
>   src/plugins/render/license/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/license/License.h PRE-CREATION 
>   src/plugins/render/license/License.cpp PRE-CREATION 
>   src/plugins/render/license/LicenseLabel.h PRE-CREATION 
>   src/plugins/render/license/LicenseLabel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107620/diff/
> 
> 
> Testing
> -------
> 
> Built, run and tested on Kubuntu Linux 12.10 (Qt 4.8.3; Intel)
> 
> 
> Screenshots
> -----------
> 
> Plain Map
>   http://git.reviewboard.kde.org/r/107620/s/892/
> Satellite View
>   http://git.reviewboard.kde.org/r/107620/s/893/
> NASA License
>   http://git.reviewboard.kde.org/r/107620/s/895/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121211/508c7c2f/attachment-0001.html>