<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107620/">http://git.reviewboard.kde.org/r/107620/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107620/diff/15/?file=98334#file98334line14" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/license/LicenseLabel.h</a>
<span style="font-weight: normal;">
(Diff revision 15)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QFont</span> <span class="n">usedFont</span><span class="p">()</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we would use this then why would you want to introduce a "usedFont()" method? There is setFont() and font() already there which you can use.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107620/diff/15/?file=98334#file98334line20" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/license/LicenseLabel.h</a>
<span style="font-weight: normal;">
(Diff revision 15)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">pText</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">pText? :) what is the "p" for?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107620/diff/15/?file=98335#file98335line30" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/license/LicenseLabel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 15)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void LicenseLabel::setText(const QString &text)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QRect</span> <span class="n">geo</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Usually we don't abbreviate variable names.
Especially not when there is a possible meaning ambivalence GEOgraphy vs. GEOmetry</pre>
</div>
<br />
<p>- Torsten</p>
<br />
<p>On December 11th, 2012, 7:27 p.m., Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Dec. 11, 2012, 7:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Task was solved according to the statements:
1. https://google-melange.appspot.com/gci/task/view/google/gci2012/8015212
2. http://www.google-melange.com/gci/task/view/google/gci2012/8006226
3. http://www.google-melange.com/gci/task/view/google/gci2012/8018213
4. http://www.google-melange.com/gci/task/view/google/gci2012/7959252</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built, run and tested on Kubuntu Linux 12.10 (Qt 4.8.3; Intel)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/maps/earth/bluemarble/bluemarble.dgml <span style="color: grey">(5eb6e2b)</span></li>
<li>data/maps/earth/citylights/citylights.dgml <span style="color: grey">(8db9b13)</span></li>
<li>data/maps/earth/openstreetmap/openstreetmap.dgml <span style="color: grey">(b26e5e1)</span></li>
<li>data/maps/earth/plain/plain.dgml <span style="color: grey">(e27eda2)</span></li>
<li>data/maps/earth/temp-july/temp-july.dgml <span style="color: grey">(e8372df)</span></li>
<li>src/ControlView.h <span style="color: grey">(756ecb7)</span></li>
<li>src/ControlView.cpp <span style="color: grey">(55d56f5)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(ae34e7c)</span></li>
<li>src/lib/AbstractFloatItem.cpp <span style="color: grey">(15ceebb)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.h <span style="color: grey">(8a590e8)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.cpp <span style="color: grey">(c8b6f99)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlLicenseTagHandler.cpp <span style="color: grey">(9b8a7bc)</span></li>
<li>src/lib/geodata/scene/GeoSceneLicense.h <span style="color: grey">(7176c12)</span></li>
<li>src/lib/geodata/scene/GeoSceneLicense.cpp <span style="color: grey">(c5a5e6d)</span></li>
<li>src/lib/graphicsview/ScreenGraphicsItem.h <span style="color: grey">(ef19746)</span></li>
<li>src/plugins/render/CMakeLists.txt <span style="color: grey">(4e550c0)</span></li>
<li>src/plugins/render/license/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/license/License.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/license/License.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/license/LicenseLabel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/license/LicenseLabel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107620/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107620/s/892/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/11/lord-1_400x100.png" style="border: 1px black solid;" alt="Plain Map" /></a>
<a href="http://git.reviewboard.kde.org/r/107620/s/893/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/11/lord-2_400x100.png" style="border: 1px black solid;" alt="Satellite View" /></a>
<a href="http://git.reviewboard.kde.org/r/107620/s/895/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/11/lord-3_1_400x100.png" style="border: 1px black solid;" alt="NASA License" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>