[Marble-devel] Review Request: Render License/Copyright into the copied/printed map

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107620/#review23152
-----------------------------------------------------------



data/maps/earth/openstreetmap/openstreetmap.dgml
<http://git.reviewboard.kde.org/r/107620/#comment17713>

    After the license change OSM also wants "You must also make it clear that the data is available under the Open Database License, and if using our map tiles, that the cartography is licensed as CC-BY-SA.".
    See http://www.openstreetmap.org/copyright/en



src/ControlView.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17714>

    This introduces a lot of code duplication between ControlView and QtMainWindow. Can you create an appropriate method in ControlView to avoid that?
    



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17710>

    The phrase "Copyright Issues" has a negative touch. I'd prefer something else like "Attribution Requirement"



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17711>

    Use 0, not NULL, as suggested in http://www.stroustrup.com/bs_faq2.html#null



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17712>

    Arial might not be installed. Let's just use the default font.
    


- Dennis Nienhüser


On Dec. 8, 2012, 5:52 a.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107620/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2012, 5:52 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Task was solved according to the statements:
>  1. https://google-melange.appspot.com/gci/task/view/google/gci2012/8015212
>  2. http://www.google-melange.com/gci/task/view/google/gci2012/8006226
> 
> 
> Diffs
> -----
> 
>   data/maps/earth/bluemarble/bluemarble.dgml 5eb6e2b 
>   data/maps/earth/citylights/citylights.dgml 8db9b13 
>   data/maps/earth/openstreetmap/openstreetmap.dgml b26e5e1 
>   data/maps/earth/plain/plain.dgml e27eda2 
>   data/maps/earth/temp-july/temp-july.dgml e8372df 
>   src/ControlView.cpp 55d56f5 
>   src/QtMainWindow.cpp ae34e7c 
> 
> Diff: http://git.reviewboard.kde.org/r/107620/diff/
> 
> 
> Testing
> -------
> 
> Built, run and tested on Ubuntu Linux 12.10 (Qt 4.8.3; Intel)
> 
> 
> Screenshots
> -----------
> 
> Marble Copyright Issues
>   http://git.reviewboard.kde.org/r/107620/s/885/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121208/b94ee101/attachment-0001.html>