[Marble-devel] Review Request: Render License/Copyright into the copied map

[Torsten Rahn]

> On Dec. 7, 2012, 7:06 p.m., René Küttner wrote:
> > Good work so far.
> > 
> > Two things that should be considered:
> >  - the strings should be translatable -> tr()
> >  - the stuff in QtMainWindow may not work in the kde version; you will have to add it to KdeMainWindow/marble_part too
> 
> Illya Kovalevskyy wrote:
>     I am afraid, I can't work with KdeMainWindow, just because I don't know how:(

Hi Illya, have you tried compiling Marble with KDE dependencies? It's not really hard. You just need to download the header files needed. 
And regarding KdeMainWindow: That class is very much similar to QtMainWindow. You'll feel right at home.

But if you really don't know how to do it then you can skip this part.


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107620/#review23136
-----------------------------------------------------------


On Dec. 7, 2012, 7:25 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107620/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 7:25 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Task was solved according to the statements:
>  1. https://google-melange.appspot.com/gci/task/view/google/gci2012/8015212
>  2. http://www.google-melange.com/gci/task/view/google/gci2012/8006226
> 
> 
> Diffs
> -----
> 
>   data/maps/earth/bluemarble/bluemarble.dgml 5eb6e2b 
>   data/maps/earth/citylights/citylights.dgml 8db9b13 
>   data/maps/earth/openstreetmap/openstreetmap.dgml b26e5e1 
>   data/maps/earth/plain/plain.dgml e27eda2 
>   data/maps/earth/temp-july/temp-july.dgml e8372df 
>   src/ControlView.cpp 55d56f5 
>   src/QtMainWindow.cpp ae34e7c 
> 
> Diff: http://git.reviewboard.kde.org/r/107620/diff/
> 
> 
> Testing
> -------
> 
> Built, run and tested on Ubuntu Linux 12.10 (Qt 4.8.3; Intel)
> 
> 
> Screenshots
> -----------
> 
> Marble Copyright Issues
>   http://git.reviewboard.kde.org/r/107620/s/885/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121207/f07763b6/attachment.html>