<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107620/">http://git.reviewboard.kde.org/r/107620/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 7th, 2012, 7:06 p.m., <b>René Küttner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good work so far.
Two things that should be considered:
- the strings should be translatable -> tr()
- the stuff in QtMainWindow may not work in the kde version; you will have to add it to KdeMainWindow/marble_part too</pre>
</blockquote>
<p>On December 7th, 2012, 7:22 p.m., <b>Illya Kovalevskyy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am afraid, I can't work with KdeMainWindow, just because I don't know how:(</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Illya, have you tried compiling Marble with KDE dependencies? It's not really hard. You just need to download the header files needed.
And regarding KdeMainWindow: That class is very much similar to QtMainWindow. You'll feel right at home.
But if you really don't know how to do it then you can skip this part.</pre>
<br />
<p>- Torsten</p>
<br />
<p>On December 7th, 2012, 7:25 p.m., Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Dec. 7, 2012, 7:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Task was solved according to the statements:
1. https://google-melange.appspot.com/gci/task/view/google/gci2012/8015212
2. http://www.google-melange.com/gci/task/view/google/gci2012/8006226</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built, run and tested on Ubuntu Linux 12.10 (Qt 4.8.3; Intel)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/maps/earth/bluemarble/bluemarble.dgml <span style="color: grey">(5eb6e2b)</span></li>
<li>data/maps/earth/citylights/citylights.dgml <span style="color: grey">(8db9b13)</span></li>
<li>data/maps/earth/openstreetmap/openstreetmap.dgml <span style="color: grey">(b26e5e1)</span></li>
<li>data/maps/earth/plain/plain.dgml <span style="color: grey">(e27eda2)</span></li>
<li>data/maps/earth/temp-july/temp-july.dgml <span style="color: grey">(e8372df)</span></li>
<li>src/ControlView.cpp <span style="color: grey">(55d56f5)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(ae34e7c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107620/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107620/s/885/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/07/Screenshot_Marble_Copyright_Issues_400x100.png" style="border: 1px black solid;" alt="Marble Copyright Issues" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>