[Marble-devel] Review Request: Caching The Atmosphere

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107581/#review23047
-----------------------------------------------------------



src/plugins/render/atmosphere/AtmospherePlugin.cpp
<http://git.reviewboard.kde.org/r/107581/#comment17617>

    The pixmap is created without setting the pixel values to anything, so random colors appear in the background part (where the radial gradient is not). To avoid that, call
    m_renderPixmap.fill(QColor(Qt::transparent));



src/plugins/render/atmosphere/AtmospherePlugin.cpp
<http://git.reviewboard.kde.org/r/107581/#comment17618>

    The radial gradient must be in the center of the pixmap, not in the center of the viewport. So imageHalfWidth and imageHalfHeight must become 1.05 * viewParams->radius() as well (please cache that value in a local variable)
    


- Dennis Nienhüser


On Dec. 5, 2012, 3:25 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107581/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2012, 3:25 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> I tried to increase performance with caching the atmosphere into QPixmap.
> Task on GCI: http://www.google-melange.com/gci/task/view/google/gci2012/7989206
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/atmosphere/AtmospherePlugin.h d662509 
>   src/plugins/render/atmosphere/AtmospherePlugin.cpp e6b531f 
> 
> Diff: http://git.reviewboard.kde.org/r/107581/diff/
> 
> 
> Testing
> -------
> 
> Successfully built on Ubuntu Linux 12.10 (Intel)
> Successfully run on Ubuntu Linux 12.10 (Intel)
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121205/e9c13de8/attachment.html>