[Marble-devel] Review Request: Caching The Atmosphere

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107581/#review23045
-----------------------------------------------------------



src/plugins/render/atmosphere/AtmospherePlugin.h
<http://git.reviewboard.kde.org/r/107581/#comment17610>

    can be const'ified: "const ViewportParams *"



src/plugins/render/atmosphere/AtmospherePlugin.cpp
<http://git.reviewboard.kde.org/r/107581/#comment17611>

    Shouldn't the else-branch be executed in any case? IIUC, this is the only place where the atmosphere is acutally rendered into the map, so the "else" should be removed.



src/plugins/render/atmosphere/AtmospherePlugin.cpp
<http://git.reviewboard.kde.org/r/107581/#comment17612>

    rename "size" to diameter



src/plugins/render/atmosphere/AtmospherePlugin.cpp
<http://git.reviewboard.kde.org/r/107581/#comment17616>

    Turn m_renderPainter into a local variable and remove m_ prefix: QPainter renderPainter( &m_renderPixmap ); QPainter::begin() is not needed in this case.



src/plugins/render/atmosphere/AtmospherePlugin.cpp
<http://git.reviewboard.kde.org/r/107581/#comment17614>

    use Qt::NoPen directly rather than introducing pen1



src/plugins/render/atmosphere/AtmospherePlugin.cpp
<http://git.reviewboard.kde.org/r/107581/#comment17613>

    reuse "diameter" here and fold into one line



src/plugins/render/atmosphere/AtmospherePlugin.cpp
<http://git.reviewboard.kde.org/r/107581/#comment17615>

    not needed if m_renderPainter is a local variable


- Bernhard Beschow


On Dec. 5, 2012, 3:25 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107581/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2012, 3:25 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> I tried to increase performance with caching the atmosphere into QPixmap.
> Task on GCI: http://www.google-melange.com/gci/task/view/google/gci2012/7989206
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/atmosphere/AtmospherePlugin.h d662509 
>   src/plugins/render/atmosphere/AtmospherePlugin.cpp e6b531f 
> 
> Diff: http://git.reviewboard.kde.org/r/107581/diff/
> 
> 
> Testing
> -------
> 
> Successfully built on Ubuntu Linux 12.10 (Intel)
> Successfully run on Ubuntu Linux 12.10 (Intel)
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121205/e2253b31/attachment-0001.html>