[Marble-devel] Review Request: Constellation Extension to Stars Plugin

[Timothy Lanzi]

> On Dec. 5, 2012, 3:20 a.m., Torsten Rahn wrote:
> > src/plugins/render/stars/StarsPlugin.cpp, line 240
> > <http://git.reviewboard.kde.org/r/107571/diff/1/?file=97136#file97136line240>
> >
> >     This should be dimmed down a bit once we use MarbleColors.h ... :-)

Fixed in diff rev 2. I was playing around with label colors and left this in by mistake.


> On Dec. 5, 2012, 3:20 a.m., Torsten Rahn wrote:
> > src/plugins/render/stars/StarsPlugin.cpp, line 349
> > <http://git.reviewboard.kde.org/r/107571/diff/1/?file=97136#file97136line349>
> >
> >     Indeed the rotated Quaternions should get "cached" (by keeping the previous one in a local variable).

Not sure how this works with new blank/dash line addition.


> On Dec. 5, 2012, 3:20 a.m., Torsten Rahn wrote:
> > src/plugins/render/stars/StarsPlugin.cpp, line 374
> > <http://git.reviewboard.kde.org/r/107571/diff/1/?file=97136#file97136line374>
> >
> >     I think we should paint these and use QPainter::setClipRegion(clipRegion);
> >     This would get rid of the  appearance/disappearance of linesegments.
> >     
> >     For providing the right clipRegion we could then use (pseudocode):
> >     QPainterPath planetShape = currentProjetion->mapShape( const ViewportParams *viewport );
> >     QRegion inner = QRegion( planetShape.toFillPolygon());
> >     QRegion outer( viewportRect );
> >     painter.setClipRegion(outer.subtracted(inner));
> >     We just need to take care and save/restore the painter ...

In a new GCI task? I would need to research this.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107571/#review23005
-----------------------------------------------------------


On Dec. 5, 2012, 3:34 a.m., Timothy Lanzi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107571/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2012, 3:34 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Constellation extension to stars plugin. 
> Extended stars plugin to read constellation.dat file and draw constellation lines/labels. 
> 
> 
> Diffs
> -----
> 
>   data/stars/constellations.dat PRE-CREATION 
>   data/stars/stars.dat 14a0723 
>   src/plugins/render/stars/StarsPlugin.h 6aeebf5 
>   src/plugins/render/stars/StarsPlugin.cpp 1bced5e 
>   tools/stars/stars.cpp 1542092 
> 
> Diff: http://git.reviewboard.kde.org/r/107571/diff/
> 
> 
> Testing
> -------
> 
> Basic operational testing. Plugin compiles without warning and runs with the data files supplied.
> 
> 
> Thanks,
> 
> Timothy Lanzi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121205/b1967ec9/attachment.html>