[Marble-devel] Review Request: Constellation Extension to Stars Plugin

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107571/#review23005
-----------------------------------------------------------



src/plugins/render/stars/StarsPlugin.h
<http://git.reviewboard.kde.org/r/107571/#comment17562>

    we usually use preincrement whenever possible. ++i ...



src/plugins/render/stars/StarsPlugin.h
<http://git.reviewboard.kde.org/r/107571/#comment17564>

    or QHash ... 



src/plugins/render/stars/StarsPlugin.cpp
<http://git.reviewboard.kde.org/r/107571/#comment17563>

    This should be dimmed down a bit once we use MarbleColors.h ... :-)



src/plugins/render/stars/StarsPlugin.cpp
<http://git.reviewboard.kde.org/r/107571/#comment17565>

    Indeed the rotated Quaternions should get "cached" (by keeping the previous one in a local variable).



src/plugins/render/stars/StarsPlugin.cpp
<http://git.reviewboard.kde.org/r/107571/#comment17566>

    I think we should paint these and use QPainter::setClipRegion(clipRegion);
    This would get rid of the  appearance/disappearance of linesegments.
    
    For providing the right clipRegion we could then use (pseudocode):
    QPainterPath planetShape = currentProjetion->mapShape( const ViewportParams *viewport );
    QRegion inner = QRegion( planetShape.toFillPolygon());
    QRegion outer( viewportRect );
    painter.setClipRegion(outer.subtracted(inner));
    We just need to take care and save/restore the painter ...


- Torsten Rahn


On Dec. 3, 2012, 11:56 p.m., Timothy Lanzi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107571/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2012, 11:56 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Constellation extension to stars plugin. 
> Extended stars plugin to read constellation.dat file and draw constellation lines/labels. 
> 
> 
> Diffs
> -----
> 
>   data/stars/constellations.dat PRE-CREATION 
>   data/stars/stars.dat 14a0723 
>   src/plugins/render/stars/StarsPlugin.h 6aeebf5 
>   src/plugins/render/stars/StarsPlugin.cpp 1bced5e 
>   tools/stars/stars.cpp 1542092 
> 
> Diff: http://git.reviewboard.kde.org/r/107571/diff/
> 
> 
> Testing
> -------
> 
> Basic operational testing. Plugin compiles without warning and runs with the data files supplied.
> 
> 
> Thanks,
> 
> Timothy Lanzi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121205/ce1f402a/attachment-0001.html>