[Marble-devel] Review Request: GSoC2012 Vector tile rendering. All the remaining code changes needed.

Torsten Rahn tackat at kde.org
Tue Aug 14 19:44:52 UTC 2012 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106013/#review17410
-----------------------------------------------------------



src/lib/ScanlineTextureMapperContext.h
<http://git.reviewboard.kde.org/r/106013/#comment13617>

    Any reason why it's not just called "tile()" ? "get"-APIs in Qt usually just refer to static getters.



src/lib/StackedTile.cpp
<http://git.reviewboard.kde.org/r/106013/#comment13618>

    Did you check by chance whether this couldn't even happen for TextureTiles? - Anyways, good that this is checked for (and yes that is one of the cases where I wouldn't favor an assert.



src/lib/TileLoader.h
<http://git.reviewboard.kde.org/r/106013/#comment13619>

    btw, I think we should mostly stick with const prefixing in parameters for consistency.



src/lib/TileLoader.cpp
<http://git.reviewboard.kde.org/r/106013/#comment13620>

    Hm, what is the reason for not accepting the Expired status? Is it just to trigger the "insert code here" action once the feature is added in the future?



src/lib/VectorTileMapper.cpp
<http://git.reviewboard.kde.org/r/106013/#comment13623>

    "zoomChanged" is not a good name for this method since the "fooChanged()" naming is usually just used for signals. Slots get usually named after what happens inside them. So here it would rather be something like "initTileRangeCoords" or such.



src/lib/geodata/data/GeoDataLatLonAltBox.h
<http://git.reviewboard.kde.org/r/106013/#comment13621>

    What is the use-case of such an API inside GeoDataLatLonAltBox? Why is it needed? :)



src/lib/layers/VectorTileLayer.cpp
<http://git.reviewboard.kde.org/r/106013/#comment13622>

    "mapChanged()" sounds like the name of a signal (since Qt consistently only names signals using the postfix "Changed". Slots are usually named after what happens inside them.



src/lib/layers/VectorTileLayer.cpp
<http://git.reviewboard.kde.org/r/106013/#comment13625>

    I guess after Cezar's latest changes we might want to have the zValue defined in addition to ensure that the buildings get displayed "under" the coordlines and above the ground layer.



src/lib/layers/VectorTileLayer.cpp
<http://git.reviewboard.kde.org/r/106013/#comment13624>

    remove?


- Torsten Rahn


On Aug. 14, 2012, 2:37 p.m., Ander Pijoan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106013/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 2:37 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> More documentation can be found here: http://techbase.kde.org/Projects/Marble/GSoC2012
> 
> Review Request #106009 needs to be previously submitted, for this to work.
> 
> During this GSoC2012 n order to make Marble download, render and manage vector data tiles, some classes have been created. The download url written in the .dgml file will download the tiles according to OpenStreetMaps tile names and it will try to parse them with all Marble's parsers. This GSoC tests have been made with the .dgml file included in this review and Kothic's server json tiles (hosted on http://osmosnimki.ru/vtile/ - please don't use it heavily-loaded projects for now) while OpenStreetMap finishes building its own data tile server. These Kothic tiles have a very similar format (https://github.com/kothic/kothic-js/wiki/Tiles-format) to the ones that OSM will have.
> 
> When Vector data is parsed it is stacked in an abstract class Tile (which is extended by ImageTile or VectorTile depending on the map) and is sent to VectorTileLayer which renders it.
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt d612723 
>   data/maps/earth/vectorosm/0/0/0.jpeg PRE-CREATION 
>   data/maps/earth/vectorosm/0/0/0.js PRE-CREATION 
>   data/maps/earth/vectorosm/0/0/0.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend.html PRE-CREATION 
>   data/maps/earth/vectorosm/legend/airportapron.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/airportrunway.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/boundary.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/bridge.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/bridleway.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/byway.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/cycleway.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/footway.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/motorway.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/primaryroad.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/railway.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/railwaystation.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/secondaryroad.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/significantbuilding.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/subway.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/summitpeak.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/track.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/tram.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/trunkroad.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/tunnel.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/unclassifiedroad.png PRE-CREATION 
>   data/maps/earth/vectorosm/legend/unsurfacedroad.png PRE-CREATION 
>   data/maps/earth/vectorosm/srtm.jpg PRE-CREATION 
>   data/maps/earth/vectorosm/vectorosm-preview.png PRE-CREATION 
>   data/maps/earth/vectorosm/vectorosm.dgml PRE-CREATION 
>   src/lib/CMakeLists.txt 5d05e21 
>   src/lib/DownloadRegion.cpp a36dc60 
>   src/lib/DownloadRegionDialog.cpp a67c7aa 
>   src/lib/ElevationModel.h 69f7e6a 
>   src/lib/ElevationModel.cpp 6e36298 
>   src/lib/FileStoragePolicy.cpp 6a505b7 
>   src/lib/FileStorageWatcher.cpp 27c5dae 
>   src/lib/GeoDataTreeModel.cpp 7c5649d 
>   src/lib/GeoGraphicsScene.cpp d03886f 
>   src/lib/GeoPainter.cpp f57a3ca 
>   src/lib/MapWizard.cpp 068e710 
>   src/lib/MarbleMap.cpp a0e2b8b 
>   src/lib/MarbleModel.cpp 838c704 
>   src/lib/MarbleRunnerManager.cpp a0b8f0d 
>   src/lib/MergedLayerDecorator.h 1a6906d 
>   src/lib/MergedLayerDecorator.cpp 119a3e2 
>   src/lib/ScanlineTextureMapperContext.h 06518b0 
>   src/lib/ScanlineTextureMapperContext.cpp ff3197b 
>   src/lib/ServerLayout.h 04c244f 
>   src/lib/ServerLayout.cpp 3a67f41 
>   src/lib/SphericalScanlineTextureMapper.cpp 0d6bb93 
>   src/lib/StackedTile.h aac0126 
>   src/lib/StackedTile.cpp a230b62 
>   src/lib/StackedTileLoader.h 87dd6b6 
>   src/lib/StackedTileLoader.cpp 812a4ed 
>   src/lib/StackedTile_p.h 2e6188c 
>   src/lib/TextureTile.h bf6e33f 
>   src/lib/TextureTile.cpp 97bae36 
>   src/lib/Tile.h PRE-CREATION 
>   src/lib/Tile.cpp PRE-CREATION 
>   src/lib/TileLoader.h c2f68ec 
>   src/lib/TileLoader.cpp 1ca214b 
>   src/lib/TileScalingTextureMapper.cpp 1ee41a5 
>   src/lib/VectorTile.h PRE-CREATION 
>   src/lib/VectorTile.cpp PRE-CREATION 
>   src/lib/VectorTileMapper.h PRE-CREATION 
>   src/lib/VectorTileMapper.cpp PRE-CREATION 
>   src/lib/blendings/Blending.h ae56e7a 
>   src/lib/blendings/BlendingAlgorithms.h 49d3206 
>   src/lib/blendings/BlendingAlgorithms.cpp 07ce60e 
>   src/lib/blendings/SunLightBlending.h 6628d22 
>   src/lib/blendings/SunLightBlending.cpp 6f2f8fb 
>   src/lib/geodata/data/GeoDataContainer.cpp bdd8fa0 
>   src/lib/geodata/data/GeoDataContainer_p.h b3a3872 
>   src/lib/geodata/data/GeoDataFeature.cpp dd5fcc8 
>   src/lib/geodata/data/GeoDataLatLonAltBox.h 15f7d16 
>   src/lib/geodata/writers/dgml/DgmlTextureTagWriter.cpp 202ea85 
>   src/lib/layers/CMakeLists.txt 7b46acf 
>   src/lib/layers/GeometryLayer.cpp 9ec92aa 
>   src/lib/layers/TextureLayer.h b6e74d9 
>   src/lib/layers/TextureLayer.cpp f5de718 
>   src/lib/layers/VectorTileLayer.h PRE-CREATION 
>   src/lib/layers/VectorTileLayer.cpp PRE-CREATION 
>   src/marble_part.cpp 808ca59 
>   src/tilecreator/CMakeLists.txt 2963831 
>   tests/TestGeoSceneWriter.cpp 4b88580 
> 
> Diff: http://git.reviewboard.kde.org/r/106013/diff/
> 
> 
> Testing
> -------
> 
> Testing done with the .dgml and the files attached.
> 
> 
> Thanks,
> 
> Ander Pijoan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120814/fbaabc47/attachment-0001.html>

More information about the Marble-devel mailing list