[Marble-devel] Review Request: New dgml tag <vectortile>, with its parser and new GeoScenes

[Ander Pijoan]

> On Aug. 14, 2012, 12:06 p.m., Dennis Nienhüser wrote:
> > src/lib/geodata/scene/GeoSceneTextureTile.cpp, line 38
> > <http://git.reviewboard.kde.org/r/106009/diff/4/?file=77512#file77512line38>
> >
> >     This seems to be used as an alternative way to determine the class type to differentiate between VectorTile and TextureTile. What about instead using an enum TileType { TextureTile, VectorTile } defined in TextureTiled?
> >

The method is inherited from GeoSceneAbstractDataset which returns a QString, so would there be any improvements by making GeoSceneTiled::VectorTile.toString()?


> On Aug. 14, 2012, 12:06 p.m., Dennis Nienhüser wrote:
> > src/lib/geodata/scene/GeoSceneTiled.h, line 123
> > <http://git.reviewboard.kde.org/r/106009/diff/4/?file=77513#file77513line123>
> >
> >     Can this one move down to TextureTile?

The tileSize is needed by booth GeoScenes to calculate which zoom level are they in.


- Ander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106009/#review17371
-----------------------------------------------------------


On Aug. 14, 2012, 1:19 p.m., Ander Pijoan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106009/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 1:19 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> For GSoC 2012 vector tile rendering, a new tag <vectortile> has been created for the dgml format and the handler for it in the dgml parser. In te begining it was thought to call it <vectorTile> as some composed words tags have also camel casing. But through the code this tile is compared with the backend="vectortile" .tolower() tag and it didn't match vectortile != vectorTile. So for consistency the tag will be <vectortile>.
> 
> Now that there are two possible tiled layers (Image tile layers with <texture> tag and Vector tile layers with <vectortile> tag) GeoSceneTexture has been turned to GeoSceneTextureTile which extends a GeoSceneTiled abstract class. Also a GeoSceneVectorTile class has been created.
> 
> GeoSceneTiled stores all the common data for layers containing tiles and then GeoSceneTextureTile and GeoSceneVectorTile can manage specific data related to them. Currently booth have the same dgml structure so this two classes have no specific attribute but they are needed afterwards for MarbleMap to know if its a VectorTile or a ImageTile layer.
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/handlers/dgml/DgmlAuxillaryDictionary.h 54693e9 
>   src/lib/geodata/handlers/dgml/DgmlAuxillaryDictionary.cpp d1452ae 
>   src/lib/geodata/handlers/dgml/DgmlBlendingTagHandler.cpp 6570a6e 
>   src/lib/geodata/handlers/dgml/DgmlDownloadPolicyTagHandler.cpp 765be23 
>   src/lib/geodata/handlers/dgml/DgmlDownloadUrlTagHandler.cpp 5fe2251 
>   src/lib/geodata/handlers/dgml/DgmlElementDictionary.h 1171392 
>   src/lib/geodata/handlers/dgml/DgmlElementDictionary.cpp c2bba42 
>   src/lib/geodata/handlers/dgml/DgmlInstallMapTagHandler.cpp d9e5e12 
>   src/lib/geodata/handlers/dgml/DgmlProjectionTagHandler.cpp d4130bf 
>   src/lib/geodata/handlers/dgml/DgmlSourceDirTagHandler.cpp 129799a 
>   src/lib/geodata/handlers/dgml/DgmlStorageLayoutTagHandler.cpp 7619175 
>   src/lib/geodata/handlers/dgml/DgmlTextureTagHandler.cpp 6d033d2 
>   src/lib/geodata/handlers/dgml/DgmlTileSizeTagHandler.cpp 07ab101 
>   src/lib/geodata/handlers/dgml/DgmlVectortileTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/dgml/DgmlVectortileTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/dgml/DgmlVisibleTagHandler.cpp a6da77d 
>   src/lib/geodata/parser/GeoSceneTypes.h 48e90e2 
>   src/lib/geodata/parser/GeoSceneTypes.cpp b076509 
>   src/lib/geodata/scene/GeoSceneMap.cpp ffa2006 
>   src/lib/geodata/scene/GeoSceneTexture.h a5d97f2 
>   src/lib/geodata/scene/GeoSceneTexture.cpp 14cb61d 
>   src/lib/geodata/scene/GeoSceneTextureTile.h PRE-CREATION 
>   src/lib/geodata/scene/GeoSceneTextureTile.cpp PRE-CREATION 
>   src/lib/geodata/scene/GeoSceneTiled.h PRE-CREATION 
>   src/lib/geodata/scene/GeoSceneTiled.cpp PRE-CREATION 
>   src/lib/geodata/scene/GeoSceneVectorTile.h PRE-CREATION 
>   src/lib/geodata/scene/GeoSceneVectorTile.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106009/diff/
> 
> 
> Testing
> -------
> 
> Testing done and works OK.
> 
> 
> Thanks,
> 
> Ander Pijoan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120814/52569449/attachment-0001.html>