<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106009/">http://git.reviewboard.kde.org/r/106009/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 14th, 2012, 12:06 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106009/diff/4/?file=77512#file77512line38" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/geodata/scene/GeoSceneTextureTile.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">const char* GeoSceneTextureTile::nodeType() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QString</span> <span class="n">GeoSceneTextureTile</span><span class="o">::</span><span class="n">type</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems to be used as an alternative way to determine the class type to differentiate between VectorTile and TextureTile. What about instead using an enum TileType { TextureTile, VectorTile } defined in TextureTiled?
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The method is inherited from GeoSceneAbstractDataset which returns a QString, so would there be any improvements by making GeoSceneTiled::VectorTile.toString()?</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 14th, 2012, 12:06 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106009/diff/4/?file=77513#file77513line123" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/geodata/scene/GeoSceneTiled.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class GeoSceneTiled : public GeoSceneAbstractDataset</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">123</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">mutable</span> <span class="n">QSize</span> <span class="n">m_tileSize</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can this one move down to TextureTile?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The tileSize is needed by booth GeoScenes to calculate which zoom level are they in.</pre>
<br />
<p>- Ander</p>
<br />
<p>On August 14th, 2012, 1:19 p.m., Ander Pijoan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Ander Pijoan.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2012, 1:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For GSoC 2012 vector tile rendering, a new tag <vectortile> has been created for the dgml format and the handler for it in the dgml parser. In te begining it was thought to call it <vectorTile> as some composed words tags have also camel casing. But through the code this tile is compared with the backend="vectortile" .tolower() tag and it didn't match vectortile != vectorTile. So for consistency the tag will be <vectortile>.
Now that there are two possible tiled layers (Image tile layers with <texture> tag and Vector tile layers with <vectortile> tag) GeoSceneTexture has been turned to GeoSceneTextureTile which extends a GeoSceneTiled abstract class. Also a GeoSceneVectorTile class has been created.
GeoSceneTiled stores all the common data for layers containing tiles and then GeoSceneTextureTile and GeoSceneVectorTile can manage specific data related to them. Currently booth have the same dgml structure so this two classes have no specific attribute but they are needed afterwards for MarbleMap to know if its a VectorTile or a ImageTile layer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing done and works OK.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/geodata/handlers/dgml/DgmlAuxillaryDictionary.h <span style="color: grey">(54693e9)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlAuxillaryDictionary.cpp <span style="color: grey">(d1452ae)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlBlendingTagHandler.cpp <span style="color: grey">(6570a6e)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlDownloadPolicyTagHandler.cpp <span style="color: grey">(765be23)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlDownloadUrlTagHandler.cpp <span style="color: grey">(5fe2251)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlElementDictionary.h <span style="color: grey">(1171392)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlElementDictionary.cpp <span style="color: grey">(c2bba42)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlInstallMapTagHandler.cpp <span style="color: grey">(d9e5e12)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlProjectionTagHandler.cpp <span style="color: grey">(d4130bf)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlSourceDirTagHandler.cpp <span style="color: grey">(129799a)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlStorageLayoutTagHandler.cpp <span style="color: grey">(7619175)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlTextureTagHandler.cpp <span style="color: grey">(6d033d2)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlTileSizeTagHandler.cpp <span style="color: grey">(07ab101)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlVectortileTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlVectortileTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlVisibleTagHandler.cpp <span style="color: grey">(a6da77d)</span></li>
<li>src/lib/geodata/parser/GeoSceneTypes.h <span style="color: grey">(48e90e2)</span></li>
<li>src/lib/geodata/parser/GeoSceneTypes.cpp <span style="color: grey">(b076509)</span></li>
<li>src/lib/geodata/scene/GeoSceneMap.cpp <span style="color: grey">(ffa2006)</span></li>
<li>src/lib/geodata/scene/GeoSceneTexture.h <span style="color: grey">(a5d97f2)</span></li>
<li>src/lib/geodata/scene/GeoSceneTexture.cpp <span style="color: grey">(14cb61d)</span></li>
<li>src/lib/geodata/scene/GeoSceneTextureTile.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/scene/GeoSceneTextureTile.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/scene/GeoSceneTiled.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/scene/GeoSceneTiled.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/scene/GeoSceneVectorTile.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/geodata/scene/GeoSceneVectorTile.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106009/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>