[Marble-devel] Review Request: AltitudeModel, altitude-profile plugin, srtm2 tilecreator

[Florian Eßer]

> On Sept. 27, 2011, 7:58 a.m., Bernhard Beschow wrote:
> > src/plugins/render/CMakeLists.txt, line 41
> > <http://git.reviewboard.kde.org/r/102637/diff/2/?file=36659#file36659line41>
> >
> >     looks like this should be changed to altitude-profile
> 
> Torsten Rahn wrote:
>     I got the feel that the word "elevation" is preferably used whenever in German we are using "Höhen..." (like the technical "Digitales Höhenmodell" which is "Digital Elevation Model (DEM)" as a technical term, or "Höhenprofil" = "Elevationprofile", etc.)
>     I think that "altitude" is preferred whenever it's just "Höhe" in German.
>     But that's just my gut feeling.

I think the reason for the comment above was just a technical one: In the initial version of this review request, there was only the code for Niko's altitude-profile plugin, but the CMakeLists tried to include the (non-existing) subdirectory elevationprofile.

But however, to continue the discussion: :-)
Here's another nice drawing showing the difference between elevation and altitude: http://en.wikipedia.org/wiki/File:Vertical_distances.svg
So basically, the term "elevation" seems to be bound to the earth's surface, while "altitude" is not.

KML uses altitude, because it can describe coordinates that are not bound to the earth's surface, for example the GPS track of a flying plane.

So taking this concept into consideration, the ElevationProfile plugin would strictly speaking be an AltitudeProfile instead (once it gains the ability to work for gpx/kml track data) and the AltitudeModel would be an ElevationModel, since it only describes the surface of the earth...


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102637/#review6860
-----------------------------------------------------------


On Sept. 29, 2011, 4:30 a.m., Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102637/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 4:30 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This patch adds an AltidudeModel that can be used to get the altitude/elevation of a coordinate. The altitude-profile plugin uses that to generate a profile for a route and calculate some statistics.
> The altitude-profile will be replaced/merged with elevationprofile plugin that was developed in parallel.
> 
> The other important part are the tiles. I used the existing TileCreator, refactored it to be more flexible and made a binary that creates the needed png tiles from the nasa srtm files. This takes a loong time, just as the upload to files.kde.org that is still running.
> 
> Please review my changes especially also those to TileCreator.
> To review this you can also use the altitude branch in the marble repository; that contains full history (which might be useful)
> 
> In the attached screenshot you can see the altitude-profile float widget (red line) and the elevationprofile float widget (black line) - not included in this request.
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt 6f16a74 
>   data/maps/earth/srtm2/0/000000/000000_000000.png PRE-CREATION 
>   data/maps/earth/srtm2/0/000000/000000_000001.png PRE-CREATION 
>   data/maps/earth/srtm2/srtm2.dgml PRE-CREATION 
>   src/icons/elevationprofile.png PRE-CREATION 
>   src/lib/AltitudeModel.h PRE-CREATION 
>   src/lib/AltitudeModel.cpp PRE-CREATION 
>   src/lib/CMakeLists.txt 328db8f 
>   src/lib/MarbleModel.h 0e4f2c8 
>   src/lib/MarbleModel.cpp c1588f8 
>   src/lib/TileCreator.h 5b58158 
>   src/lib/TileCreator.cpp 0ffa155 
>   src/lib/routing/AlternativeRoutesModel.h 945a745 
>   src/marble.qrc c92a412 
>   src/plugins/render/CMakeLists.txt 37075b3 
>   src/plugins/render/elevationprofile/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/elevationprofile/ElevationProfileConfigWidget.ui PRE-CREATION 
>   src/plugins/render/elevationprofile/ElevationProfileFloatItem.h PRE-CREATION 
>   src/plugins/render/elevationprofile/ElevationProfileFloatItem.cpp PRE-CREATION 
>   src/plugins/render/elevationprofile/elevationprofile.qrc PRE-CREATION 
>   src/plugins/render/elevationprofile/flag-red-mirrored.png PRE-CREATION 
>   tools/tilecreator-srtm2/CMakeLists.txt PRE-CREATION 
>   tools/tilecreator-srtm2/main.cpp PRE-CREATION 
>   tools/tilecreator-srtm2/tccore.h PRE-CREATION 
>   tools/tilecreator-srtm2/tccore.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102637/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> altitude profile in action
>   http://git.reviewboard.kde.org/r/102637/s/263/
> 
> 
> Thanks,
> 
> Niko Sams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110929/9ab466b3/attachment-0001.html>