[Marble-devel] Review Request: Add buttons to save and load routes as *.kml file from within the Routing Widget.

Torsten Rahn tackat at kde.org
Sat Sep 10 16:45:46 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102539/#review6388
-----------------------------------------------------------


Hi, 
I just tried your patch and I see the need for this functionality. Situation is a bit similar as with the route color patch though (I hope you don't hate me for that):
On one hand there is a minor buglet:
* If there is no route calculated the save button should be grayed out.

On the other hand we always want to keep UI clutter low.

This feature is certainly useful for power users, so it should be available somehow (I tried it and it works great!).
Currently I think it's not in the optimal place: It should appear right next to the Search button (also because translations of Search sometimes will become long and will possibly move the buttons out of scope). 

I wonder whether we could move those two buttons below the listview or even put them into a context menu that appears if the user clicks with the right mouse button onto the result listview. This would take into account that this feature is rather a feature for power users. Any suggestions? :-)  

- Torsten


On Sept. 6, 2011, 1:36 p.m., Florian Eßer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102539/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2011, 1:36 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> I often use Marble's routing ability to plan somewhat longer routes with a lot
> of manually-tweaked waypoints (e.g. for cycling). I would like to be able not
> only to export the final gpx/kml file of the route, but also to save and reload
> it's "source" (the waypoints).
> 
> Basically, this functionality is already built in. The recently edited route is
> automatically saved to ~/.local/share/marble/routing/route.kml and restored on
> startup. But if I just quickly want to plan another route inbetween, all the
> previous work on the "big" route is gone.
> 
> Since I don't like to manually backup and restore the route.kml every time, I
> created this small patch to add save and load buttons to the RoutingWidget.
> 
> 
> This addresses bug 281278.
>     http://bugs.kde.org/show_bug.cgi?id=281278
> 
> 
> Diffs
> -----
> 
>   src/lib/routing/RoutingWidget.cpp 4e84201 
>   src/lib/routing/RoutingWidget.ui 7d0620c 
> 
> Diff: http://git.reviewboard.kde.org/r/102539/diff
> 
> 
> Testing
> -------
> 
> It worked for me...
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110910/6e8bcc7c/attachment.html>


More information about the Marble-devel mailing list