<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102539/">http://git.reviewboard.kde.org/r/102539/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi,
I just tried your patch and I see the need for this functionality. Situation is a bit similar as with the route color patch though (I hope you don't hate me for that):
On one hand there is a minor buglet:
* If there is no route calculated the save button should be grayed out.
On the other hand we always want to keep UI clutter low.
This feature is certainly useful for power users, so it should be available somehow (I tried it and it works great!).
Currently I think it's not in the optimal place: It should appear right next to the Search button (also because translations of Search sometimes will become long and will possibly move the buttons out of scope).
I wonder whether we could move those two buttons below the listview or even put them into a context menu that appears if the user clicks with the right mouse button onto the result listview. This would take into account that this feature is rather a feature for power users. Any suggestions? :-) </pre>
<br />
<p>- Torsten</p>
<br />
<p>On September 6th, 2011, 1:36 p.m., Florian Eßer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Florian Eßer.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2011, 1:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I often use Marble's routing ability to plan somewhat longer routes with a lot
of manually-tweaked waypoints (e.g. for cycling). I would like to be able not
only to export the final gpx/kml file of the route, but also to save and reload
it's "source" (the waypoints).
Basically, this functionality is already built in. The recently edited route is
automatically saved to ~/.local/share/marble/routing/route.kml and restored on
startup. But if I just quickly want to plan another route inbetween, all the
previous work on the "big" route is gone.
Since I don't like to manually backup and restore the route.kml every time, I
created this small patch to add save and load buttons to the RoutingWidget.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It worked for me...</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=281278">281278</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/routing/RoutingWidget.cpp <span style="color: grey">(4e84201)</span></li>
<li>src/lib/routing/RoutingWidget.ui <span style="color: grey">(7d0620c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102539/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>