[Marble-devel] Review Request: make Marble Touch almost just work (TM)

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102536/#review6293
-----------------------------------------------------------

Ship it!


Looks fine (assuming QT_IMPORT_DIR exists for Qt 4.6 as well).

- Dennis


On Sept. 5, 2011, 11:11 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102536/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2011, 11:11 p.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Summary
> -------
> 
> Install the declarative plugin into ${QT_IMPORT_DIR} rather than ${MARBLE_PLUGIN_INSTALL_PATH}.
> This avoids having to adjust QML_IMPORT_PATH prior to executing marble-touch.
> 
> TODO: Add a .cmake file to search for Qt-components for MeeGo in order to make it just work (TM). This should be a separate patch, though.
> 
> 
> This addresses bug 281379.
>     http://bugs.kde.org/show_bug.cgi?id=281379
> 
> 
> Diffs
> -----
> 
>   MarbleMacros.cmake a8a61bd 
>   src/plugins/declarative/CMakeLists.txt f50f479 
>   src/plugins/qt-components/CMakeLists.txt df233ba 
> 
> Diff: http://git.reviewboard.kde.org/r/102536/diff
> 
> 
> Testing
> -------
> 
> Having installed the qt-components package for MeeGo, marble-touch starts successfully w/o having to set QML_IMPORT_PATH manually.
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110906/c48624d7/attachment.html>