<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102536/">http://git.reviewboard.kde.org/r/102536/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine (assuming QT_IMPORT_DIR exists for Qt 4.6 as well).</pre>
<br />
<p>- Dennis</p>
<br />
<p>On September 5th, 2011, 11:11 p.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Dennis Nienhüser.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Sept. 5, 2011, 11:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Install the declarative plugin into ${QT_IMPORT_DIR} rather than ${MARBLE_PLUGIN_INSTALL_PATH}.
This avoids having to adjust QML_IMPORT_PATH prior to executing marble-touch.
TODO: Add a .cmake file to search for Qt-components for MeeGo in order to make it just work (TM). This should be a separate patch, though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Having installed the qt-components package for MeeGo, marble-touch starts successfully w/o having to set QML_IMPORT_PATH manually.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=281379">281379</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>MarbleMacros.cmake <span style="color: grey">(a8a61bd)</span></li>
<li>src/plugins/declarative/CMakeLists.txt <span style="color: grey">(f50f479)</span></li>
<li>src/plugins/qt-components/CMakeLists.txt <span style="color: grey">(df233ba)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102536/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>