[Marble-devel] Review Request: Plasma Runner which starts Marble for entered lonlat coordinates

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102849/
-----------------------------------------------------------

(Updated Oct. 24, 2011, 7:17 p.m.)


Review request for Marble.


Changes
-------

Found a way to have the commandline settings working for the Qt-only version, by simply passing the arguments from the commandline around as QVariantMap, including streaming to the init() and readSettings() methods. Okay this way?

There could be some scoping in main() in qtmain.cpp, so that before the line "return app.exec();" all helper objects are removed and cleaned and thus do not stay around for the complete runtime of the program. Did not put into this patch, to make the actual feature changes easier to review :)

So consider this patch complete in this version, all functionality present and working. Please give it some final review and your thumb up (or down, if needed).


Description
-------

Initial version of a Plasma Runner which uses Marble. So far can do:
* detect lonlat coordinates and start a new Marble instance showing that coordinates with OSM
* detect Marble bookmarks containing the search string in name or description (unless CDATA)
  and start a new Marble instance showing that bookmark's coordinates with OSM

Support for Marble runners is not in the scope of this patch.

And parsing lonlat needs to be improved, still. WIP in another branch of mine.


Diffs (updated)
-----

  src/plasmarunner/plasmarunner.h PRE-CREATION 
  src/plasmarunner/plasmarunner.cpp PRE-CREATION 
  src/CMakeLists.txt b9b4a3b 
  src/QtMainWindow.h 8c3cfe3 
  src/QtMainWindow.cpp e57feca 
  src/kdemain.cpp eee55df 
  src/plasmarunner/CMakeLists.txt PRE-CREATION 
  src/plasmarunner/Messages.sh PRE-CREATION 
  src/plasmarunner/main.cpp PRE-CREATION 
  src/plasmarunner/plasma-runner-marble.desktop PRE-CREATION 
  src/qtmain.cpp 3d6d1c7 

Diff: http://git.reviewboard.kde.org/r/102849/diff/diff


Testing
-------

Used a few times.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111024/b13af0ee/attachment.html>