<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102849/">http://git.reviewboard.kde.org/r/102849/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2011, 7:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Found a way to have the commandline settings working for the Qt-only version, by simply passing the arguments from the commandline around as QVariantMap, including streaming to the init() and readSettings() methods. Okay this way?
There could be some scoping in main() in qtmain.cpp, so that before the line "return app.exec();" all helper objects are removed and cleaned and thus do not stay around for the complete runtime of the program. Did not put into this patch, to make the actual feature changes easier to review :)
So consider this patch complete in this version, all functionality present and working. Please give it some final review and your thumb up (or down, if needed).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initial version of a Plasma Runner which uses Marble. So far can do:
* detect lonlat coordinates and start a new Marble instance showing that coordinates with OSM
* detect Marble bookmarks containing the search string in name or description (unless CDATA)
and start a new Marble instance showing that bookmark's coordinates with OSM
Support for Marble runners is not in the scope of this patch.
And parsing lonlat needs to be improved, still. WIP in another branch of mine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used a few times.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmarunner/plasmarunner.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/plasmarunner.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b9b4a3b)</span></li>
<li>src/QtMainWindow.h <span style="color: grey">(8c3cfe3)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(e57feca)</span></li>
<li>src/kdemain.cpp <span style="color: grey">(eee55df)</span></li>
<li>src/plasmarunner/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasmarunner/plasma-runner-marble.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qtmain.cpp <span style="color: grey">(3d6d1c7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102849/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>