[Marble-devel] Review Request: Remove the non-plugin Measure Tool in favor of MeasureToolPlugin.

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103263/#review8595
-----------------------------------------------------------


Thanks for moving the measure tool into its own plugin. This will make Marble more flexible.

One remark though: Please merge this patch with the commit where you created the plugin, such that the commit history of the measure tool is preserved. Besides keeping the commit history, this also avoids having a point in history where two measure tools are present (rule of thumb: every commit should represent a releasable state). Thanks in advance! :)

- Bernhard Beschow


On Nov. 26, 2011, 11:42 p.m., Mike Henning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103263/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2011, 11:42 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Remove the non-plugin Measure Tool in favor of MeasureToolPlugin.
> 
> It's probably best to commit MeasureToolPlugin first.
> https://git.reviewboard.kde.org/r/103262/
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMap.h c837e2e 
>   src/lib/MarbleMap.cpp 47858d9 
>   src/lib/MarbleWidget.h c32ca68 
>   src/lib/MarbleWidget.cpp 0e83077 
>   src/lib/MarbleWidgetInputHandler.h a8b96f5 
>   src/lib/MarbleWidgetInputHandler.cpp 95dff20 
>   src/lib/layers/CMakeLists.txt 031e058 
>   src/lib/layers/MeasureTool.h 38bbac3 
>   src/lib/layers/MeasureTool.cpp 56691f0 
> 
> Diff: http://git.reviewboard.kde.org/r/103263/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mike Henning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111129/087f512d/attachment.html>