<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103263/">http://git.reviewboard.kde.org/r/103263/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for moving the measure tool into its own plugin. This will make Marble more flexible.
One remark though: Please merge this patch with the commit where you created the plugin, such that the commit history of the measure tool is preserved. Besides keeping the commit history, this also avoids having a point in history where two measure tools are present (rule of thumb: every commit should represent a releasable state). Thanks in advance! :)</pre>
<br />
<p>- Bernhard</p>
<br />
<p>On November 26th, 2011, 11:42 p.m., Mike Henning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Mike Henning.</div>
<p style="color: grey;"><i>Updated Nov. 26, 2011, 11:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the non-plugin Measure Tool in favor of MeasureToolPlugin.
It's probably best to commit MeasureToolPlugin first.
https://git.reviewboard.kde.org/r/103262/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleMap.h <span style="color: grey">(c837e2e)</span></li>
<li>src/lib/MarbleMap.cpp <span style="color: grey">(47858d9)</span></li>
<li>src/lib/MarbleWidget.h <span style="color: grey">(c32ca68)</span></li>
<li>src/lib/MarbleWidget.cpp <span style="color: grey">(0e83077)</span></li>
<li>src/lib/MarbleWidgetInputHandler.h <span style="color: grey">(a8b96f5)</span></li>
<li>src/lib/MarbleWidgetInputHandler.cpp <span style="color: grey">(95dff20)</span></li>
<li>src/lib/layers/CMakeLists.txt <span style="color: grey">(031e058)</span></li>
<li>src/lib/layers/MeasureTool.h <span style="color: grey">(38bbac3)</span></li>
<li>src/lib/layers/MeasureTool.cpp <span style="color: grey">(56691f0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103263/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>