[Marble-devel] Review Request: Preview Map feature for Map Wizard

Bernhard Beschow bbeschow at cs.tu-berlin.de
Wed Nov 16 21:44:40 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103146/#review8245
-----------------------------------------------------------



src/lib/MapWizard.cpp
<http://git.reviewboard.kde.org/r/103146/#comment7043>

    Please pass "this" as a parent widget. Otherwise the preview dialog gets its own entry in the taskbar. Moreover it also seems like passing no parent leads to focus issues after closing the preview dialog.


- Bernhard Beschow


On Nov. 15, 2011, 5:02 p.m., Utku Aydın wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103146/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2011, 5:02 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Added preview map feature for Map Wizard.
> 
> 
> Diffs
> -----
> 
>   src/lib/MapWizard.h 50776bf 
>   src/lib/MapWizard.cpp 9ebd686 
>   src/lib/MapWizard.ui 880b86c 
> 
> Diff: http://git.reviewboard.kde.org/r/103146/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with a newly created map from a bitmap image.
> 
> 
> Thanks,
> 
> Utku Aydın
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111116/2ad031c5/attachment.html>


More information about the Marble-devel mailing list