[Marble-devel] Review Request: Preview Map feature for Map Wizard

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103146/#review8244
-----------------------------------------------------------


Thanks for the patch, works great here with the public transport map! [1]

As usual, here are some minor nitpicks: ;-)
In order to let users zoom in and out, I suggest to activate the Navigation plugin. Moreover, you could help the user judge about the map if you could zoom out such that the whole map becomes visible. For now, it is IMO sufficient to always display the whole planet. As part of a future patch, the area covered by the map should be respected (which seems to be available for the WMS case only).

[1] http://tile.xn--pnvkarte-m4a.de/tilegen/{zoomLevel}/{x}/{y}.png

- Bernhard Beschow


On Nov. 15, 2011, 5:02 p.m., Utku Aydın wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103146/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2011, 5:02 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Added preview map feature for Map Wizard.
> 
> 
> Diffs
> -----
> 
>   src/lib/MapWizard.h 50776bf 
>   src/lib/MapWizard.cpp 9ebd686 
>   src/lib/MapWizard.ui 880b86c 
> 
> Diff: http://git.reviewboard.kde.org/r/103146/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with a newly created map from a bitmap image.
> 
> 
> Thanks,
> 
> Utku Aydın
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111116/8b977a19/attachment.html>