[Marble-devel] Re: kdeplasma-addons Marble wallpaper does not build

[Bernhard Beschow]

Hi,

Am Dienstag, 17. Mai 2011, 19:55:46 schrieb Anne-Marie Mahfouf:
> On Tuesday 17 May 2011 19:17:01 you wrote:
> > HI,
> > 
> > > I have an error in kdeplasma-addons
> > > 
> > > kdeplasma-addons/wallpapers/marble/marble.cpp:116:16: error: ‘class
> > > Marble::MarbleMap’ has no member named ‘zoomView’
> > 
> > I have removed the zoom API from MarbleMap in order to properly solve bug
> > 199259 (blurry maps). The goal was to have exactly one "official" way in
> > MarbleMap to set the size of the globe instead of having lots of competing
> > ways (we had about four!). Since the radius yields the most precise
> > results,
> > it is now the only way to set the size of the globe.
> > 
> > The good news is that you basically have two options right now:
> > 1) Reimplement zooming by either copying the code from Marble or inventing
> > your own zoom concept.
> > 2) Use the radius, which allows to stick to the preferred radius of the
> > map, yielding sharp results.
> > 
> > Which option would you like to take?
> > 
> > Greetings,
> > Bernhard
> > 
> > > Thanks in advance,
> > > 
> > > Anne-Marie
> > > _______________________________________________
> > > Marble-devel mailing list
> > > Marble-devel at kde.org
> > > https://mail.kde.org/mailman/listinfo/marble-devel
> Hi,
> 
> I am not the Marble wallpaper plugin maintainer at all, only someone who 
> builds it (I guess not many devels build kdeplasma-addons with Marble support 
> or you would already have complains). So no option for me, I don't care as 
> long as it still builds.

I wasn't assuming that you were the maintainer of the plugin. I was rather assuming that you wanted to know how to fix compilation or at least start a communication process to get the problem solved. That's why I provided some background of my changes along with some decisions that need to be made.

> It's your call anyway.
> If this wallpaper plugin is not maintained it should be removed. If it is 
> maintained, it should be fixed and each time you change something in Marble 
> that might affect it, you should also change it or at least use 
> http://lxr.kde.org to look what code also is affected and tell the maintainers.

It is a well-known fact among developers that Marble does not guarantee API/ABI stability between minor releases of KDE, which implies that things will break from time to time. Therefore, code that uses Marble is required to be actively maintained.

Moreover, it is not always possible for me to fix any given problem, like in this case. The reason is that I'm not very familiar with the code, so I don't feel like "fixing" it, especially when decisions need to be made. All I can do is to rely on maintainers who shall speak up when they see issues, such that we can solve them together. If there is no maintainer and I can't fix the problem myself, then I'm relying on other developers to take action.

> 
> Please find a way to fix this, thanks.
> 

Therefore, if the Marble wallpaper plugin is not maintained and does not compile, it should either be entirely removed or be moved into another module where it gets a new maintainer.

-- Bernhard