[Marble-devel] Re: Review Request: Fix Bug 262330 - Wrong current location in Marble, GPSD reports correct position

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6327/#review9623
-----------------------------------------------------------


I don't have much knowledge about the locale stuff. But formally and in terms of intention it looks ok to me.

- Torsten


On Jan. 12, 2011, 9:23 p.m., Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6327/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2011, 9:23 p.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> We use gpsmm (part of gpsd) to retrieve the current location from gpsd. Unfortunately gpsd uses the C locale to output data while gpsmm parses it using the current locale. This fails if the decimal point is different.
> 
> 
> This addresses bug 262330.
>     https://bugs.kde.org/show_bug.cgi?id=262330
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdConnection.h 1213564 
>   trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdConnection.cpp 1213564 
> 
> Diff: http://svn.reviewboard.kde.org/r/6327/diff
> 
> 
> Testing
> -------
> 
> Works both with en_US and de_DE locale with this patch. Without the patch, de_DE retrieves wrong data (floating point interpreted as int for lon and lat).
> 
> I *think* that changing the locale like this is sane here because gpsd runs in its own thread, so *AFAIK* only that thread is affected by the locale change. This is backed up by the status bar still showing the locale specific decimal point, likewise for newly opened config dialogs.
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110113/a643a304/attachment.htm