[Marble-devel] Review Request: Fix Bug 262330 - Wrong current location in Marble, GPSD reports correct position

Dennis Nienhüser earthwings at gentoo.org
Wed Jan 12 22:23:04 CET 2011

This is an automatically generated e-mail. To reply, visit:

Review request for marble.


We use gpsmm (part of gpsd) to retrieve the current location from gpsd. Unfortunately gpsd uses the C locale to output data while gpsmm parses it using the current locale. This fails if the decimal point is different.

This addresses bug 262330.


  trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdConnection.h 1213564 
  trunk/KDE/kdeedu/marble/src/plugins/positionprovider/gpsd/GpsdConnection.cpp 1213564 

Diff: http://svn.reviewboard.kde.org/r/6327/diff


Works both with en_US and de_DE locale with this patch. Without the patch, de_DE retrieves wrong data (floating point interpreted as int for lon and lat).

I *think* that changing the locale like this is sane here because gpsd runs in its own thread, so *AFAIK* only that thread is affected by the locale change. This is backed up by the status bar still showing the locale specific decimal point, likewise for newly opened config dialogs.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110112/9ba303b1/attachment.htm 

More information about the Marble-devel mailing list