[Marble-devel] Re: Review Request: Make the Overview Map Plugin use QIcon instead of QSvgRenderer and create an About dialog for it

[Daniel Marth]

> On Jan. 9, 2011, 8:11 a.m., Torsten Rahn wrote:
> > Doesn't looked finished to me yet. Of course the new overview map should also get displayed in the actual overview map (outside the settings dialog) when a png/jpg file is used.

I just tested it again and it works SVG, PNG and JPG. I haven't tested the other filetyes yet.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6309/#review9578
-----------------------------------------------------------


On Jan. 9, 2011, 11:32 a.m., Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6309/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2011, 11:32 a.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds an about dialog to the overview map plugin and changes from the SVG-specific types to QIcon.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.h 1212922 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp 1212922 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMapConfigWidget.ui 1212922 
> 
> Diff: http://svn.reviewboard.kde.org/r/6309/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110109/a266be2b/attachment.htm