[Marble-devel] Re: Review Request: Make the Overview Map Plugin use QIcon instead of QSvgRenderer and create an About dialog for it

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6309/#review9579
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.h
<http://svn.reviewboard.kde.org/r/6309/#comment10563>

    Setter, shouldn't be const.



/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp
<http://svn.reviewboard.kde.org/r/6309/#comment10564>

    We should introduce a convenience ctor for this class/struct to avoid the repeated code. Not part of this task of course.
    



/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp
<http://svn.reviewboard.kde.org/r/6309/#comment10565>

    "All files (*.*)" should be another filter choice to cover foo.JPEG and similar.


- Dennis


On Jan. 9, 2011, 3:20 a.m., Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6309/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2011, 3:20 a.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds an about dialog to the overview map plugin and changes from the SVG-specific types to QIcon.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.h 1212922 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp 1212922 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMapConfigWidget.ui 1212922 
> 
> Diff: http://svn.reviewboard.kde.org/r/6309/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110109/03cb72af/attachment-0001.htm